Skip to content

Commit 4b34581

Browse files
committed
Add updates to README, pyproject
1 parent cc90a09 commit 4b34581

2 files changed

Lines changed: 5 additions & 0 deletions

File tree

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ This package contains common Python utility classes and functions.
1717
* Reading a YAML config file and putting the contents in os.environ
1818
* Creating a logger in the appropriate format
1919
* Obfuscating a value using bcrypt
20+
* Parsing/building Research Catalog identifiers
2021

2122
## Usage
2223
```python
@@ -81,6 +82,7 @@ This repo uses the [Main-QA-Production](https://github.com/NYPL/engineering-gene
8182
- Cut a feature branch off of `main`
8283
- Commit changes to your feature branch
8384
- File a pull request against `main` and assign a reviewer (who must be an owner)
85+
- Include relevant updates to pyproject.toml and README
8486
- In order for the PR to be accepted, it must pass all unit tests, have no lint issues, and update the CHANGELOG (or contain the `Skip-Changelog` label in GitHub)
8587
- After the PR is accepted, merge into `main`
8688
- Merge `main` > `qa`

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ config-helper = [
6363
obfuscation-helper = [
6464
"bcrypt>=4.0.1"
6565
]
66+
research-catalog-identifier-helper = [
67+
"requests>=2.28.1"
68+
]
6669
development = [
6770
"nypl_py_utils[avro-encoder,kinesis-client,kms-client,mysql-client,oauth2-api-client,postgresql-client,postgresql-pool-client,redshift-client,s3-client,config-helper,obfuscation-helper]",
6871
"flake8>=6.0.0",

0 commit comments

Comments
 (0)