Skip to content

fix: websocket check to prevent runtime conflict on network framework #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DjDeveloperr merged 2 commits into from
May 22, 2026
Merged

fix: websocket check to prevent runtime conflict on network framework #60

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7f625
fix: websocket check to prevent runtime conflict on network framework
NathanWalker May 22, 2026
a6969be
fix: preserve websocket fallback when global is missing
DjDeveloperr May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/nativescript-inspector/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -891,7 +891,7 @@ function createInspectorSocket(
url: string,
handlers: InspectorSocketHandlers,
): InspectorSocket {
if (typeof WebSocket === "function") {
if (typeof WebSocket !== "undefined" && isBrowserWebSocket(WebSocket)) {
const socket = new WebSocket(url) as any;
socket.onmessage = (event: { data: string }) => {
handlers.onMessage(String(event.data));
Expand All @@ -912,6 +912,23 @@ function createInspectorSocket(
);
}

// NativeScript exposes Objective-C class as a global "function", and
// recent iOS SDKs ship a top-level `WebSocket` class in Network.framework.
// `typeof WebSocket === "function"` therefore matches that native class and
// `new WebSocket(url)` fails with "No initializer found that matches
// constructor invocation." Require browser-style readyState constants and a
// `send`/`close` prototype to confirm the global is a real WebSocket polyfill
// (e.g. @valor/nativescript-websockets) before using it.
function isBrowserWebSocket(ctor: any): boolean {
return (
typeof ctor === "function" &&
ctor.CONNECTING === 0 &&
ctor.OPEN === 1 &&
typeof ctor.prototype?.send === "function" &&
typeof ctor.prototype?.close === "function"
);
}

function createNSURLSessionWebSocket(
url: string,
handlers: InspectorSocketHandlers,
Expand Down
Loading