From 7a19509c7a31a7f8d704e2136cc6e3074aad7a9c Mon Sep 17 00:00:00 2001 From: Osei Fortune Date: Fri, 23 Oct 2026 20:48:24 -0400 Subject: [PATCH] fix(build): give every engine a Tools entry build.ps1 runs under `Set-StrictMode -Version Latest`, where reading a missing hashtable key with dot syntax throws. Only hermes defined `Tools`, so the v8, quickjs and jsc framework builds failed at the tool-staging loop after the cargo build succeeded. --- template/build.ps1 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/template/build.ps1 b/template/build.ps1 index 53b7b8c..e035daf 100644 --- a/template/build.ps1 +++ b/template/build.ps1 @@ -63,10 +63,10 @@ Write-Host "Repo root : $RepoRoot" # `classic` is the default V8 workspace crate; the rest are the napi engine packages. $EngineMap = @{ classic = @{ Package = 'nativescript'; NpmName = '@nativescript/windows' } - v8 = @{ Dir = 'windows-v8'; Lib = 'windows_v8'; Dlls = @(); Features = @('host_dll'); NpmName = '@nativescript/windows-v8' } - quickjs = @{ Dir = 'windows-quickjs'; Lib = 'windows_quickjs'; Dlls = @(); Features = @('host_dll'); NpmName = '@nativescript/windows-quickjs' } + v8 = @{ Dir = 'windows-v8'; Lib = 'windows_v8'; Dlls = @(); Features = @('host_dll'); NpmName = '@nativescript/windows-v8'; Tools = @() } + quickjs = @{ Dir = 'windows-quickjs'; Lib = 'windows_quickjs'; Dlls = @(); Features = @('host_dll'); NpmName = '@nativescript/windows-quickjs'; Tools = @() } hermes = @{ Dir = 'windows-hermes'; Lib = 'windows_hermes'; Dlls = @('hermes.dll', 'hermes-icu.dll'); Features = @('host_dll'); NpmName = '@nativescript/windows-hermes'; Tools = @('hermesc.exe') } - jsc = @{ Dir = 'windows-jsc'; Lib = 'windows_jsc'; Dlls = @('JavaScriptCore.dll', 'icuin77.dll', 'icuuc77.dll', 'icudt77.dll'); Features = @('host_dll', 'jsc_link'); NpmName = '@nativescript/windows-jsc' } + jsc = @{ Dir = 'windows-jsc'; Lib = 'windows_jsc'; Dlls = @('JavaScriptCore.dll', 'icuin77.dll', 'icuuc77.dll', 'icudt77.dll'); Features = @('host_dll', 'jsc_link'); NpmName = '@nativescript/windows-jsc'; Tools = @() } } $EngineInfo = $EngineMap[$Engine] if ($Engine -ne 'classic') {