adding new flag --core-flag to allow custom environment variables to Neo Core

Author: romdalf

cmd/neoctl/instance.go

@@ -32,6 +32,7 @@ var (
 	instAll      bool
 	instCoreVer  string
 	instUIVer    string
+	instCoreEnv  []string
 	instSMB      bool
 	instPortSMB  int
 
@@ -289,6 +290,12 @@ var instanceConfigureCmd = &cobra.Command{
 			inst.UIVersion = instUIVer
 		}
 
+		if cmd.Flags().Changed("core-env") {
+			inst.CoreEnv = instCoreEnv
+		} else if !ok {
+			inst.CoreEnv = instCoreEnv
+		}
+
 		if cmd.Flags().Changed("smb") {
 			inst.SMB = instSMB
 		} else if !ok {
@@ -732,6 +739,7 @@ func init() {
 	instanceConfigureCmd.Flags().StringVar(&instMemory, "memory", "8G", "Memory limit")
 	instanceConfigureCmd.Flags().StringVar(&instCoreVer, "core", "", "Neo Core version (e.g. v1.2.3)")
 	instanceConfigureCmd.Flags().StringVar(&instUIVer, "ui", "", "Neo UI version (e.g. v1.2.3)")
+	instanceConfigureCmd.Flags().StringSliceVar(&instCoreEnv, "core-env", nil, "Additional environment variables for Neo Core (e.g. VAR=value)")
 	instanceConfigureCmd.Flags().BoolVar(&instSMB, "smb", false, "Enable a SMB server for test only")
 	instanceConfigureCmd.Flags().IntVar(&instPortSMB, "port-smb", 445, "SMB server port")
 

internal/config/config.go

@@ -89,9 +89,10 @@ type InstanceConfig struct {
 	GPU         string `json:"gpu"`
 	CPU         string `json:"cpu"`
 	Memory      string `json:"memory"`
-	CoreVersion string `json:"neocore_version,omitempty"`
-	UIVersion   string `json:"neoui_version,omitempty"`
-	SMB         bool   `json:"smb"`
+	CoreVersion string   `json:"neocore_version,omitempty"`
+	UIVersion   string   `json:"neoui_version,omitempty"`
+	CoreEnv     []string `json:"core_env,omitempty"`
+	SMB         bool     `json:"smb"`
 	PortSMB     int    `json:"port_smb"`
 }
 

internal/config/config_test.go

@@ -87,6 +87,7 @@ func TestSaveAndLoadInstanceConfig(t *testing.T) {
 		PortSQL: 5432,
 		SMB:     true,
 		PortSMB: 445,
+		CoreEnv: []string{"TEST_ENV=1"},
 	}
 
 	if err := SaveInstanceConfig(instances); err != nil {

internal/runner/compose.go

@@ -96,6 +96,9 @@ const composeTemplate = `services:
     environment:
       - PORT=8080
       - PYTHONUNBUFFERED=1
+{{- range .Instance.CoreEnv }}
+      - {{ . }}
+{{- end }}
     restart: unless-stopped
 
   neoui:

internal/runner/compose_test.go

@@ -106,6 +106,7 @@ func TestGenerateComposeFile(t *testing.T) {
 		Name:    "test-smb",
 		SMB:     true,
 		PortSMB: 4450,
+		CoreEnv: []string{"CUSTOM_VAR1=one", "CUSTOM_VAR2=two"},
 	}
 	bundle := config.Config{} // Empty bundle is fine for this test
 
@@ -126,6 +127,8 @@ func TestGenerateComposeFile(t *testing.T) {
 		"container_name: test-smb-neosmb",
 		"4450:445", // Port mapping
 		"test-smb-neosmb:/storage", // Volume
+		"CUSTOM_VAR1=one",
+		"CUSTOM_VAR2=two",
 	}
 
 	for _, s := range expectedStrings {