NSOL-5942: removing config existence checks

Author: sushma-m1

netapp_dataops_traditional/netapp_dataops/config/dataset_manager.py

@@ -204,19 +204,6 @@ def _setup_new_root_volume(self, config: DatasetManagerConfig) -> None:
 
         logger.info(f"\n  Setting up new Dataset Manager root volume '{root_volume_name}'...")
 
-        # Check if we can connect to ONTAP
-        from ..traditional.core import _retrieve_config
-        from ..traditional.exceptions import InvalidConfigError
-        
-        try:
-            _retrieve_config(print_output=False)
-        except (InvalidConfigError, FileNotFoundError):
-            # Base config doesn't exist yet - defer volume creation
-            logger.info(f"  Note: Cannot create root volume on ONTAP - base configuration not yet complete.")
-            logger.info(f"  Configuration has been saved.")
-            logger.info(f"  Please create the root volume '{root_volume_name}' manually or reconfigure after base setup is complete.")
-            return
-        
         while True:  # Loop for retrying with different names if needed
             try:
                 # Check if volume already exists
@@ -266,21 +253,9 @@ def _setup_new_root_volume(self, config: DatasetManagerConfig) -> None:
     def _get_volume_info(self, volume_name: str) -> Optional[Dict[str, Any]]:
         """Get volume information from ONTAP.
         
-        Returns None if ONTAP connection cannot be established (e.g., during initial config).
+        Returns None if ONTAP connection cannot be established or volume not found.
         """
         try:
-            # Check if base ONTAP config exists before trying to connect
-            from ..traditional.core import _retrieve_config
-            from ..traditional.exceptions import InvalidConfigError
-            
-            try:
-                _retrieve_config(print_output=False)
-            except (InvalidConfigError, FileNotFoundError):
-                # Base config doesn't exist yet - can't connect to ONTAP
-                if self.print_output:
-                    logger.info(f"  Note: Cannot validate volume on ONTAP - base configuration not yet complete")
-                return None
-            
             # Use list_volumes to find the specific volume
             # Always suppress output to avoid displaying volume lists during user input
             volumes = volume_operations.list_volumes(print_output=False)
@@ -289,26 +264,18 @@ def _get_volume_info(self, volume_name: str) -> Optional[Dict[str, Any]]:
                     return volume
             return None
         except Exception as e:
+            # Could be a connection error or other issue
+            # Return None to allow graceful handling by caller
             if self.print_output:
-                logger.info(f"  Error retrieving volume information: {e}")
+                logger.info(f"  Note: Could not retrieve volume information: {e}")
             return None
 
     def _junction_path_exists(self, junction_path: str, exclude_volume: str = None) -> bool:
         """Check if a junction path is already in use by any volume.
         
-        Returns False if ONTAP connection cannot be established.
+        Returns False if ONTAP connection cannot be established or on error.
         """
         try:
-            # Check if base ONTAP config exists before trying to connect
-            from ..traditional.core import _retrieve_config
-            from ..traditional.exceptions import InvalidConfigError
-            
-            try:
-                _retrieve_config(print_output=False)
-            except (InvalidConfigError, FileNotFoundError):
-                # Base config doesn't exist yet - can't check junction paths
-                return False
-            
             # Always suppress output to avoid displaying volume lists during validation
             volumes = volume_operations.list_volumes(print_output=False)
             for volume in volumes: