Pull request #45: Bugfix/fix github issues

Merge in SIE-BB/netapp-dataops-toolkit from bugfix/fix-github-issues to release-v3.1.0

* commit '823767469d90a30d8d05c3f842e89d5c06072406':
  NSOL-6207: minor correction in tool name
  NSOL-6244: fixing fstab write failure when /etc/fstab does not exist
  NSOL-6208: adding support for custom ONTAP API port configuration
  NSOL-6207: making tool names compatible with Claude Desktop

Author: sushma-m1

netapp_dataops_traditional/netapp_dataops/config/dataset_manager.py

@@ -570,7 +570,20 @@ def _add_fstab_entry_safely(self, fstab_entry: str, nfs_target: str, mountpoint:
             except Exception as e:
                 logger.info(f"  ERROR: Failed to write temporary file: {e}")
                 return False
-            
+
+            # Step 6b: Create /etc/fstab if it does not exist
+            if not os.path.exists(fstab_path):
+                try:
+                    if needs_sudo:
+                        subprocess.run(['sudo', 'touch', fstab_path], check=True,
+                                      capture_output=True, text=True)
+                    else:
+                        open(fstab_path, 'w').close()
+                    logger.info(f"  Created new /etc/fstab")
+                except Exception as e:
+                    logger.info(f"  ERROR: Failed to create /etc/fstab: {e}")
+                    return False
+
             # Step 7: Execute all operations in a single sudo session if needed
             if needs_sudo:
                 logger.info("  Elevated privileges required to modify /etc/fstab...")

netapp_dataops_traditional/netapp_dataops/mcp_server/netapp_dataops_ontap_mcp.py

@@ -489,7 +489,7 @@ async def create_flexcache_tool(
         raise
 
 
-@mcp.tool(name="Create CIFS Share")
+@mcp.tool(name="CreateCIFSShare")
 async def create_cifs_share_tool(
     name : str,
     volume_name : str,
@@ -540,7 +540,7 @@ async def create_cifs_share_tool(
         raise
 
 
-@mcp.tool(name="List CIFS Shares")
+@mcp.tool(name="ListCIFSShares")
 async def list_cifs_shares_tool(
     svm : Optional[str] = None,
     name_pattern : Optional[str] = None,
@@ -601,7 +601,7 @@ async def list_cifs_shares_tool(
         raise
 
 
-@mcp.tool(name="Get CIFS Share")
+@mcp.tool(name="GetCIFSShare")
 async def get_cifs_share_tool(
     name : str,
     svm : str,

netapp_dataops_traditional/netapp_dataops/traditional/core/connection.py

@@ -75,16 +75,38 @@ def _instantiate_connection(config: Dict[str, Any], connectionType: str = "ONTAP
 
         ssl_cert_path = _get_ssl_cert_path(config)
 
-        # Security: verify is always True to enforce SSL certificate validation.
-        # When ssl_cert_path is provided, _apply_custom_ssl_context pins the
-        # CA cert and relaxes hostname/SAN checks (common for ONTAP self-signed
-        # certs) while still verifying the certificate chain.
-        netappConfig.CONNECTION = NetAppHostConnection(
+        # Extract a custom port if the hostname is in "host:port" format.
+        # This avoids the double-port URL issue (e.g., host:8001:443) that
+        # occurs when the ONTAP SDK appends its default port 443 to a hostname
+        # that already contains a port number.
+        custom_port = None
+        if ":" in ontapClusterMgmtHostname:
+            host_part, port_part = ontapClusterMgmtHostname.rsplit(":", 1)
+            if port_part.isdigit():
+                port_num = int(port_part)
+                if 1 <= port_num <= 65535:
+                    ontapClusterMgmtHostname = host_part
+                    custom_port = port_num
+                else:
+                    raise InvalidConfigError(
+                        f"Invalid port number '{port_num}' in hostname '{config['hostname']}'. "
+                        "Port must be between 1 and 65535."
+                    )
+
+        connection_kwargs = dict(
             host=ontapClusterMgmtHostname,
             username=ontapClusterAdminUsername,
             password=ontapClusterAdminPassword,
             verify=True,
         )
+        if custom_port is not None:
+            connection_kwargs["port"] = custom_port
+
+        # Security: verify is always True to enforce SSL certificate validation.
+        # When ssl_cert_path is provided, _apply_custom_ssl_context pins the
+        # CA cert and relaxes hostname/SAN checks (common for ONTAP self-signed
+        # certs) while still verifying the certificate chain.
+        netappConfig.CONNECTION = NetAppHostConnection(**connection_kwargs)
 
         if ssl_cert_path:
             _apply_custom_ssl_context(netappConfig.CONNECTION, ssl_cert_path)