Skip to content

Commit 6f403bc

Browse files
committed
Infrastructure: Updates for GraalVM version 21
- Switch to using sdkman for managing JDKs - Update `sbt.sh` script to run the command automatically - Minor updates to tests and GHA
1 parent e2942c3 commit 6f403bc

4 files changed

Lines changed: 25 additions & 53 deletions

File tree

.github/workflows/main.yml

Lines changed: 14 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,8 @@ jobs:
2222

2323
- uses: graalvm/setup-graalvm@v1
2424
with:
25-
version: '22.2.0'
26-
java-version: '17'
27-
28-
- name: Install Graal.js
29-
run: |
30-
gu install js
31-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
25+
java-version: '21'
26+
distribution: 'graalvm'
3227

3328
- uses: sbt/setup-sbt@v1
3429

@@ -53,8 +48,6 @@ jobs:
5348
node --version
5449
echo "** JAVA_HOME"
5550
echo $JAVA_HOME
56-
echo "** GRAAL_HOME"
57-
echo $GRAAL_HOME
5851
echo "** java path and version"
5952
readlink -f `which java`
6053
java -version
@@ -86,13 +79,8 @@ jobs:
8679

8780
- uses: graalvm/setup-graalvm@v1
8881
with:
89-
version: '22.2.0'
90-
java-version: '17'
91-
92-
- name: Install Graal.js
93-
run: |
94-
gu install js
95-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
82+
java-version: '21'
83+
distribution: 'graalvm'
9684

9785
- uses: sbt/setup-sbt@v1
9886

@@ -122,13 +110,8 @@ jobs:
122110

123111
- uses: graalvm/setup-graalvm@v1
124112
with:
125-
version: '22.2.0'
126-
java-version: '17'
127-
128-
- name: Install Graal.js
129-
run: |
130-
gu install js
131-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
113+
java-version: '21'
114+
distribution: 'graalvm'
132115

133116
- uses: sbt/setup-sbt@v1
134117

@@ -159,16 +142,11 @@ jobs:
159142

160143
- uses: graalvm/setup-graalvm@v1
161144
with:
162-
version: '22.2.0'
163-
java-version: '17'
145+
java-version: '21'
146+
distribution: 'graalvm'
164147

165148
- uses: sbt/setup-sbt@v1
166149

167-
- name: Install Graal.js
168-
run: |
169-
gu install js
170-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
171-
172150
- uses: actions/setup-node@v3
173151
with:
174152
node-version: '16'
@@ -193,13 +171,8 @@ jobs:
193171

194172
- uses: graalvm/setup-graalvm@v1
195173
with:
196-
version: '22.2.0'
197-
java-version: '17'
198-
199-
- name: Install Graal.js
200-
run: |
201-
gu install js
202-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
174+
java-version: '21'
175+
distribution: 'graalvm'
203176

204177
- uses: sbt/setup-sbt@v1
205178

@@ -225,13 +198,8 @@ jobs:
225198

226199
- uses: graalvm/setup-graalvm@v1
227200
with:
228-
version: '22.2.0'
229-
java-version: '17'
230-
231-
- name: Install Graal.js
232-
run: |
233-
gu install js
234-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
201+
java-version: '21'
202+
distribution: 'graalvm'
235203

236204
- uses: sbt/setup-sbt@v1
237205

@@ -262,13 +230,8 @@ jobs:
262230

263231
- uses: graalvm/setup-graalvm@v1
264232
with:
265-
version: '22.2.0'
266-
java-version: '17'
267-
268-
- name: Install Graal.js
269-
run: |
270-
gu install js
271-
echo "GRAAL_HOME=$GRAALVM_HOME" >> $GITHUB_ENV
233+
java-version: '21'
234+
distribution: 'graalvm'
272235

273236
- uses: sbt/setup-sbt@v1
274237

build.sbt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ val commonSettings =
2424
resolvers += "netlogoheadless" at "https://dl.cloudsmith.io/public/netlogo/netlogo/maven/",
2525
libraryDependencies ++= Seq(
2626
"org.nlogo" % "netlogoheadless" % nlDependencyVersion,
27+
"org.graalvm.polyglot" % "polyglot" % "23.1.10",
28+
"org.graalvm.polyglot" % "js" % "23.1.10" pomOnly(),
2729
"org.scalaz" %% "scalaz-core" % scalazVersion,
2830
"com.typesafe.play" %% "play-json" % playJsonVersion,
2931
"com.lihaoyi" %% "scalatags" % "0.12.0" % "test",

netlogo-web/src/test/scala/TestEngineType.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import org.scalatest.funsuite.AnyFunSuite
88
class TestEngineType extends AnyFunSuite {
99

1010
test("engine name") {
11-
assert((new GraalJS).jsRuntime.getEngine.getImplementationName.startsWith("Graal"))
11+
assert((new GraalJS).jsRuntime.getEngine.getImplementationName.contains("Graal"))
1212
}
1313

1414
}

sbt.sh

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
#!/bin/bash
22

3-
export JAVA_HOME=$GRAAL_HOME
3+
SDKMAN_DIR="${SDKMAN_DIR:-$HOME/.sdkman}"
4+
GRAAL_VERSION="21.0.10-graal"
5+
6+
if [ -f "$SDKMAN_DIR/bin/sdkman-init.sh" ]; then
7+
source "$SDKMAN_DIR/bin/sdkman-init.sh"
8+
sdk use java "$GRAAL_VERSION"
9+
fi
10+
# else: leave JAVA_HOME as-is (e.g. set by CI via graalvm/setup-graalvm)
411

512
# GraalVM includes binaries for node and npm that would supercede
613
# any installed on the system, which we do not want. -Jeremy B 2/2019

0 commit comments

Comments
 (0)