Fix up various warnings

Author: apanda

framework/Cargo.toml

@@ -10,7 +10,6 @@ doctest = false
 [dependencies]
 libc = ">= 0.2.4"
 time = ">=0.1.0"
-simd = { git = "https://github.com/huonw/simd" }
 getopts = "*"
 byteorder = "*"
 clippy = { version = "*", optional = true }

framework/src/headers/ip.rs

@@ -9,7 +9,7 @@ use std::slice;
 use utils::Flow;
 
 /// IP header using SSE
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct IpHeader {
     version_to_len: u32,

framework/src/headers/mac.rs

@@ -5,7 +5,7 @@ use std::fmt;
 use std::hash::Hash;
 use std::hash::Hasher;
 
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct MacAddress {
     pub addr: [u8; 6],
@@ -66,7 +66,7 @@ impl Hash for MacAddress {
 }
 
 /// A packet's MAC header.
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct MacHeader {
     pub dst: MacAddress,

framework/src/headers/null_header.rs

@@ -1,7 +1,7 @@
 use super::EndOffset;
 use std::fmt;
 
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct NullHeader;
 

framework/src/headers/tcp.rs

@@ -3,7 +3,7 @@ use headers::IpHeader;
 use std::default::Default;
 use std::fmt;
 
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct TcpHeader {
     src_port: u16,

framework/src/headers/udp.rs

@@ -4,8 +4,7 @@ use std::default::Default;
 use std::fmt;
 
 /// UDP header using SSE
-// #[repr(C, packed)]
-#[derive(Debug, Default)]
+#[derive(Default)]
 #[repr(C, packed)]
 pub struct UdpHeader {
     src_port: u16,

test/maglev/src/nf.rs

@@ -93,7 +93,7 @@ pub fn maglev<T: 'static + Batch<Header = NullHeader>, S: Scheduler + Sized>(
         .parse::<MacHeader>()
         .transform(box move |pkt| {
             assert!(pkt.refcnt() == 1);
-            let mut hdr = pkt.get_mut_header();
+            let hdr = pkt.get_mut_header();
             hdr.swap_addresses();
         })
         .group_by(

test/tcp_check/src/nf.rs

@@ -24,7 +24,8 @@ pub fn tcp_nf<T: 'static + Batch<Header = NullHeader>>(parent: T) -> Composition
                 "payload: {:x} {:x} {:x} {:x}",
                 payload[0], payload[1], payload[2], payload[3]
             );
-            println!("Src {} dst {}", flow.src_port, flow.dst_port);
+            let (src, dst) = (flow.src_port, flow.dst_port);
+            println!("Src {} dst {}", src, dst);
         })
         .parse::<UdpHeader>()
         .map(box |pkt| {