Skip to content

Commit e3f3508

Browse files
committed
rename
1 parent 88abc18 commit e3f3508

7 files changed

Lines changed: 40 additions & 15 deletions

File tree

src/Lemon.ModuleNavigation.Avaloniaui/Regions/Region.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
using Avalonia.Controls;
22
using Avalonia.Controls.Templates;
3-
using Avalonia.Markup.Xaml.Templates;
43
using Lemon.ModuleNavigation.Abstractions;
54
using Lemon.ModuleNavigation.Core;
65
using Microsoft.Extensions.DependencyInjection;

src/Lemon.ModuleNavigation.Sample/ViewModels/MainViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ await _dialogService.ShowDialog(content,
104104

105105
UnloadViewCommand = ReactiveCommand.Create<NavigationContext>((context) =>
106106
{
107-
_regionManager.RequestUnload(context);
107+
_regionManager.RequestViewUnload(context);
108108
});
109109

110110
_regionManager.NavigationSubscribe<NavigationContext>(n =>

src/Lemon.ModuleNavigation.WpfSample/MainWindowViewModel.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ await _dialogService.ShowDialog(content,
8282
});
8383
UnloadViewCommand = ReactiveCommand.Create<NavigationContext>((context) =>
8484
{
85-
_regionManager.RequestUnload(context);
85+
_regionManager.RequestViewUnload(context);
8686
});
8787
}
8888

src/Lemon.ModuleNavigation/Abstractions/IRegionManager.cs

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,20 @@
22

33
namespace Lemon.ModuleNavigation.Abstractions;
44

5-
public interface IRegionManager: IObservable<NavigationContext>, IObservable<IRegion>
5+
public interface IRegionManager : IObservable<NavigationContext>, IObservable<IRegion>
66
{
77
void AddRegion(string regionName, IRegion region);
88
IRegion? GetRegion(string regionName);
9-
void RequestNavigate(string regionName, string viewName, NavigationParameters? parameters = null);
9+
10+
void RequestViewNavigate(string regionName, string viewName, NavigationParameters? parameters = null);
1011
[Obsolete("requestNew was obsolete.Consider IsNavigationTarget() in INavigationAware instead.")]
1112
void RequestNavigate(string regionName, string viewName, bool requestNew, NavigationParameters? parameters = null);
12-
void RequestUnload(string regionName, string viewName);
13-
void RequestUnload(NavigationContext context);
13+
void RequestViewUnload(string regionName, string viewName);
14+
void RequestViewUnload(NavigationContext context);
15+
16+
17+
void RequestModuleNavigate(string regionName, string moduleName, NavigationParameters? parameters);
18+
void RequestModuleNavigate(string regionName, IModule module, NavigationParameters? parameters);
19+
void RequestModuleUnload(string moduleName, string viewName);
20+
void RequestModuleUnload(IModule module);
1421
}

src/Lemon.ModuleNavigation/ModuleManager.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public ModuleManager(IEnumerable<IModule> modules,
2323
_regionCache = [];
2424
_modulesCache = new ConcurrentDictionary<string, IModule>(modules.ToDictionary(m => m.Key, m => m));
2525
Modules = _modulesCache.Values;
26-
ActiveModules = new ObservableCollection<IModule>(_modulesCache
26+
ActiveModules = [.. _modulesCache
2727
.Where(m =>
2828
{
2929
return !m.Value.LoadOnDemand;
@@ -32,7 +32,7 @@ public ModuleManager(IEnumerable<IModule> modules,
3232
{
3333
m.Value.Initialize();
3434
return m.Value;
35-
}));
35+
})];
3636
}
3737
public ObservableCollection<IModule> ActiveModules
3838
{

src/Lemon.ModuleNavigation/NavigationHandler.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ public void OnNavigateTo(string moduleKey, NavigationParameters? parameters)
3535
public void OnNavigateTo(string regionName,
3636
string viewName)
3737
{
38-
RegionManager.RequestNavigate(regionName, viewName, null);
38+
RegionManager.RequestViewNavigate(regionName, viewName, null);
3939
}
4040
public void OnNavigateTo(string regionName,
4141
string viewName,
4242
NavigationParameters navigationParameters)
4343
{
44-
RegionManager.RequestNavigate(regionName, viewName, navigationParameters);
44+
RegionManager.RequestViewNavigate(regionName, viewName, navigationParameters);
4545
}
4646

4747
public void OnViewUnload(string regionName, string viewName)
4848
{
49-
RegionManager.RequestUnload(regionName, viewName);
49+
RegionManager.RequestViewUnload(regionName, viewName);
5050
}
5151

5252
void IDisposable.Dispose()

src/Lemon.ModuleNavigation/RegionManager.cs

Lines changed: 22 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public void RequestNavigate(string regionName, string viewName, bool requestNew,
4141
});
4242
}
4343
}
44-
public void RequestNavigate(string regionName, string viewName, NavigationParameters? parameters = null)
44+
public void RequestViewNavigate(string regionName, string viewName, NavigationParameters? parameters = null)
4545
{
4646
var context = new NavigationContext(viewName, regionName, _serviceProvider, parameters);
4747
if (_regions.TryGetValue(regionName, out var region))
@@ -93,7 +93,7 @@ public void AddRegion(string regionName, IRegion region)
9393
return region;
9494
}
9595

96-
public void RequestUnload(string regionName, string viewName)
96+
public void RequestViewUnload(string regionName, string viewName)
9797
{
9898
if (_regions.TryGetValue(regionName, out var region))
9999
{
@@ -104,7 +104,7 @@ public void RequestUnload(string regionName, string viewName)
104104
throw new RegionNameNotFoundException(nameof(regionName));
105105
}
106106
}
107-
public void RequestUnload(NavigationContext navigationContext)
107+
public void RequestViewUnload(NavigationContext navigationContext)
108108
{
109109
if (_regions.TryGetValue(navigationContext.RegionName, out var region))
110110
{
@@ -165,4 +165,23 @@ private void ToRegionsObservers(IRegion region)
165165
}
166166
}
167167

168+
public void RequestModuleNavigate(string regionName, string moduleName, NavigationParameters? parameters)
169+
{
170+
throw new NotImplementedException();
171+
}
172+
173+
public void RequestModuleNavigate(string regionName, IModule module, NavigationParameters? parameters)
174+
{
175+
throw new NotImplementedException();
176+
}
177+
178+
public void RequestModuleUnload(string moduleName, string viewName)
179+
{
180+
throw new NotImplementedException();
181+
}
182+
183+
public void RequestModuleUnload(IModule module)
184+
{
185+
throw new NotImplementedException();
186+
}
168187
}

0 commit comments

Comments
 (0)