Fix kotlin resolution ambiguity

- By un-defaulting ItemProvider#get(), Kotlin will no longer treat item providers as potential lambdas
- Removed .setItemProvider(Supplier), because Kotlin cannot infer if there is supposed to be one unnamed parameter (from .setItemProvider(Function), or none)

Author: NichtStudioCode

invui-kotlin/src/main/kotlin/xyz/xenondevs/invui/item/ReactiveItems.kt

@@ -17,7 +17,7 @@ private fun <S : Item.Builder<*>> S.setReactiveItemProvider(
     itemProviderProvider: Provider<ItemProvider>
 ): S {
     addModifier { item -> itemProviderProvider.observeWeak(item) { weakItem -> weakItem.notifyWindows() } }
-    return setItemProvider(itemProviderProvider) as S
+    return setItemProvider { itemProviderProvider.get() } as S
 }
 
 @OverloadResolutionByLambdaReturnType

invui/src/main/java/xyz/xenondevs/invui/item/CustomBoundItem.java

@@ -76,7 +76,6 @@ public void removeViewer(AbstractWindow who, int how) {
         }
     }
 
-    @SuppressWarnings("unchecked")
     non-sealed static class Builder<G extends Gui> implements BoundItem.Builder<G> {
 
         protected BiConsumer<Item, G> bindHandler = (item, gui) -> {};
@@ -93,12 +92,6 @@ public Builder<G> setItemProvider(ItemProvider itemProvider) {
             return this;
         }
 
-        @Override
-        public Builder<G> setItemProvider(Supplier<ItemProvider> itemProvider) {
-            this.itemProviderFn = (viewer, gui) -> itemProvider.get();
-            return this;
-        }
-        
         @Override
         public Builder<G> setItemProvider(Function<Player, ItemProvider> itemProvider) {
             this.itemProviderFn = (viewer, gui) -> itemProvider.apply(viewer);

invui/src/main/java/xyz/xenondevs/invui/item/CustomItem.java

@@ -11,7 +11,6 @@
 import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 import java.util.function.Function;
-import java.util.function.Supplier;
 
 class CustomItem extends AbstractItem {
 
@@ -73,12 +72,6 @@ public Builder setItemProvider(ItemProvider itemProvider) {
             return this;
         }
 
-        @Override
-        public Builder setItemProvider(Supplier<ItemProvider> itemProvider) {
-            this.itemProviderFn = viewer -> itemProvider.get();
-            return this;
-        }
-        
         @Override
         public Builder setItemProvider(Function<Player, ItemProvider> itemProvider) {
             this.itemProviderFn = itemProvider;

invui/src/main/java/xyz/xenondevs/invui/item/Item.java

@@ -9,7 +9,6 @@
 import java.util.function.BiConsumer;
 import java.util.function.Consumer;
 import java.util.function.Function;
-import java.util.function.Supplier;
 
 /**
  * A UI element for use in {@link Gui Guis}.
@@ -56,10 +55,6 @@ static Item simple(ItemProvider itemProvider) {
         return builder().setItemProvider(itemProvider).build();
     }
 
-    static Item simple(Supplier<ItemProvider> itemProvider) {
-        return builder().setItemProvider(itemProvider).build();
-    }
-    
     static Item simple(Function<Player, ItemProvider> itemProvider) {
         return builder().setItemProvider(itemProvider).build();
     }
@@ -68,8 +63,6 @@ interface Builder<S extends Builder<S>> {
 
         S setItemProvider(ItemProvider itemProvider);
 
-        S setItemProvider(Supplier<ItemProvider> itemProvider);
-        
         S setItemProvider(Function<Player, ItemProvider> itemProvider);
 
         S async(ItemProvider placeholder);

invui/src/main/java/xyz/xenondevs/invui/item/ItemBuilder.java

@@ -29,7 +29,7 @@
  * Utility for building (localized) {@link ItemStack ItemStacks}.
  */
 @SuppressWarnings("UnstableApiUsage")
-public class ItemBuilder implements ItemProvider {
+public final class ItemBuilder implements ItemProvider {
 
     private ItemStack itemStack;
     private @Nullable Component name;
@@ -76,9 +76,20 @@ public ItemBuilder(ItemStack base) {
         }
     }
 
+    /**
+     * Builds the {@link ItemStack} in {@link Locale#US}.
+     * 
+     * @return The {@link ItemStack}
+     */
+    @Override
+    public ItemStack get() {
+        return get(Locale.US);
+    }
+    
     /**
      * Builds the {@link ItemStack}
      *
+     * @param locale The {@link Locale} to use for localization
      * @return The {@link ItemStack}
      */
     @Override

invui/src/main/java/xyz/xenondevs/invui/item/ItemProvider.java

@@ -28,8 +28,6 @@ public interface ItemProvider extends Supplier<ItemStack>, Cloneable {
      *
      * @return The {@link ItemStack}
      */
-    default ItemStack get() {
-        return get(Locale.US);
-    }
+    ItemStack get();
 
 }

invui/src/main/java/xyz/xenondevs/invui/item/ItemWrapper.java

@@ -9,7 +9,7 @@
  * An {@link ItemProvider} that just returns the {@link ItemStack}
  * passed to it in the constructor regardless of the {@link UUID players uuid}.
  */
-public class ItemWrapper implements ItemProvider {
+public final class ItemWrapper implements ItemProvider {
 
     private ItemStack itemStack;
 
@@ -22,6 +22,11 @@ public ItemStack get(Locale locale) {
         return itemStack;
     }
 
+    @Override
+    public ItemStack get() {
+        return itemStack;
+    }
+    
     @Override
     public ItemWrapper clone() {
         try {