fix: Gtk helpers

Author: nlogozzo

flatpak/org.nickvision.application.json

@@ -15,7 +15,6 @@
     "cleanup":[
         "/include",
         "/lib/cmake",
-        "/lib/debug",
         "/lib/pkgconfig",
         "/man",
         "*.a"

inno/setup.iss

@@ -99,7 +99,4 @@ Name: "{autodesktop}\{#MyAppShortName}"; Filename: "{app}\Release\{#MyAppExeName
 [Run]
 Filename: "{app}\vc_redist.exe"; Parameters: "/install /quiet /norestart"
 Filename: "{app}\windowsappruntimeinstall.exe"
-Filename: "{app}\Release\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
-
-[InstallDelete]
-Type: filesandordirs; Name: {group}\*;
+Filename: "{app}\Release\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent

org.nickvision.application.gnome/include/helpers/gtkhelpers.h

@@ -17,7 +17,7 @@ namespace Nickvision::Application::GNOME::Helpers::GtkHelpers
     void addToBox(GtkBox* box, GtkWidget* widget, bool addSeparator = false);
     /**
      * @brief Runs the function on the main UI thread.
-     * @param function The function to run
+     * @param function The function to run 
      */
     void dispatchToMainThread(const std::function<void()>& function);
     /**
@@ -50,7 +50,7 @@ namespace Nickvision::Application::GNOME::Helpers::GtkHelpers
      * @param selected An optional index that should be selected
      * @param allowEllipse Whether or not to allow ellipses in the combo row
      */
-    void setComboRowModel(AdwComboRow* row, const std::vector<std::string>& strs, size_t selected, bool allowEllipse = true);
+    void setComboRowModel(AdwComboRow* row, const std::vector<std::string>& strs, const size_t& selected, bool allowEllipse = true);
 }
 
 #endif //GTKHELPERS_H

org.nickvision.application.gnome/src/helpers/gtkhelpers.cpp

@@ -1,5 +1,4 @@
 #include "helpers/gtkhelpers.h"
-#include <adwaita.h>
 
 namespace Nickvision::Application::GNOME::Helpers
 {
@@ -71,10 +70,11 @@ namespace Nickvision::Application::GNOME::Helpers
             }), nullptr);
         }
         adw_combo_row_set_model(row, G_LIST_MODEL(list));
+        g_object_unref(list);
         adw_combo_row_set_selected(row, selectedIndex);
     }
 
-    void GtkHelpers::setComboRowModel(AdwComboRow* row, const std::vector<std::string>& strs, size_t selected, bool allowEllipse)
+    void GtkHelpers::setComboRowModel(AdwComboRow* row, const std::vector<std::string>& strs, const size_t& selected, bool allowEllipse)
     {
         GtkStringList* list{ gtk_string_list_new(nullptr) };
         for(const std::string& str : strs)
@@ -91,7 +91,8 @@ namespace Nickvision::Application::GNOME::Helpers
             }), nullptr);
         }
         adw_combo_row_set_model(row, G_LIST_MODEL(list));
-        if(selected >= 0 && selected < strs.size())
+        g_object_unref(list);
+        if(selected < strs.size())
         {
             adw_combo_row_set_selected(row, selected);
         }