Skip to content

Commit e7dce05

Browse files
committed
Null-safety migration
Used pull request to migrate because original package author no responding.
1 parent 2033106 commit e7dce05

4 files changed

Lines changed: 19 additions & 13 deletions

File tree

lib/src/data/network_manager.dart

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,12 @@ import 'package:data_connection_checker/data_connection_checker.dart';
22

33
import '../domain/inetwork_manager.dart';
44

5+
///Implementation of NetworkManager
56
class NetworkManager implements INetworkManager {
7+
///NetworkManager recive a connection Checker
68
NetworkManager(this.connectionChecker);
79

10+
/// Access to connectionChecker properties
811
final DataConnectionChecker connectionChecker;
912

1013
@override
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
/// Interface for Network Manager
12
abstract class INetworkManager {
3+
/// Future that returns true if there is internet connection
24
Future<bool> get isConnected;
35
}

pubspec.yaml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,19 @@
11
name: network_manager
22
description: Dart package which manages data connection.
3-
version: 1.0.0
3+
version: 2.0.0
44
# homepage: https://www.example.com
5-
65
environment:
7-
sdk: ">=2.10.0 <3.0.0"
6+
sdk: ">=2.12.0 <3.0.0"
87

98
dependencies:
10-
data_connection_checker: ^0.3.4
9+
data_connection_checker:
10+
git:
11+
url: git://github.com/uSlashVlad/data_connection_checker.git
1112
equatable: ^2.0.0
12-
meta: ^1.1.8
13-
path: ^1.7.0
13+
meta: ^1.3.0
14+
path: ^1.8.0
1415

1516
dev_dependencies:
16-
mockito: ^5.0.3
17-
test: ^1.14.4
17+
mocktail: ^0.1.1
18+
test: ^1.16.8
1819
very_good_analysis: ^2.0.0

test/network_manager_test.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
import 'package:mockito/mockito.dart';
1+
import 'package:mocktail/mocktail.dart';
22
import 'package:test/test.dart';
33

44
import 'package:network_manager/network_manager.dart';
55

66
class MockDataConnectionChecker extends Mock implements DataConnectionChecker {}
77

88
void main() {
9-
NetworkManager networkInfo;
10-
MockDataConnectionChecker dataConnectionChecker;
9+
late NetworkManager networkInfo;
10+
late MockDataConnectionChecker dataConnectionChecker;
1111

1212
setUp(() {
1313
dataConnectionChecker = MockDataConnectionChecker();
@@ -22,14 +22,14 @@ void main() {
2222
final tIsConnected = Future.value(true);
2323

2424
when(
25-
dataConnectionChecker.hasConnection,
25+
() => dataConnectionChecker.hasConnection,
2626
).thenAnswer((_) => tIsConnected);
2727

2828
// side effects -> collect the result to test
2929
final result = networkInfo.isConnected;
3030

3131
// expectations -> compare result to expected value
32-
verify(dataConnectionChecker.hasConnection);
32+
verify(() => dataConnectionChecker.hasConnection);
3333
expect(result, tIsConnected);
3434
},
3535
);

0 commit comments

Comments
 (0)