Change default reward to -1

Author: Mak Muftic

cmd/payout.go

@@ -49,7 +49,7 @@ func init() {
 	payoutCmd.Flags().StringVar(
 		&totalReward,
 		"payout-reward",
-		"",
+		"-1",
 		"[REQUIRED] total reward pool in Planck",
 	)
 	payoutCmd.Flags().StringVar(

cmd/start.go

@@ -230,7 +230,7 @@ func init() {
 	startCmd.Flags().StringVar(
 		&payoutTotalReward,
 		"payout-reward",
-		"",
+		"-1",
 		"[OPTIONAL] Total reward pool in Planck. If omitted, total balance of load balancer wallet will be considered as payout reward",
 	)
 

cmd/validation.go

@@ -15,7 +15,8 @@ func ValidatePayoutFlags(
 	var err error
 	var rewardAsFloat64 float64
 
-	if payoutReward == "" {
+	// if total reward is determined as wallet balance
+	if payoutReward == "-1" {
 		if payoutAddress == "" {
 			return 0, errors.New("Unable to set reward amount to entire wallet balance if fee address not provided")
 		} else {
@@ -35,7 +36,7 @@ func ValidatePayoutFlags(
 		}
 	} else {
 		rewardAsFloat64, err = strconv.ParseFloat(payoutReward, 64)
-		if err != nil {
+		if err != nil || rewardAsFloat64 < -1 {
 			return 0, errors.New("invalid total reward value")
 		}
 	}

internal/script/payout.go

@@ -39,8 +39,8 @@ func ExecutePayout(
 		return nil, fmt.Errorf("invalid private key, %v", err)
 	}
 
-	if totalReward == 0 {
-		// distribute entire balance on address if total reward not set
+	// distribute entire balance on address if total reward not set
+	if totalReward == -1 {
 		balance, err := payout.GetBalance(metadataLatest, keyringPair, substrateAPI)
 		if err != nil {
 			return nil, err