Skip to content

Commit 791beff

Browse files
authored
fix: use currentNodeParams from NetworkNavigation and fix ESLint warnings (#313)
1 parent b5e314c commit 791beff

2 files changed

Lines changed: 12 additions & 11 deletions

File tree

public/main.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ document.addEventListener("DOMContentLoaded", async() => {
3333
new HomeView(secureDataSet, nsn);
3434

3535
window.addEventListener("package-info-closed", () => {
36-
currentNodeParams = null;
36+
networkNavigation.currentNodeParams = null;
3737
packageInfoOpened = false;
3838
});
3939

@@ -76,8 +76,8 @@ document.addEventListener("DOMContentLoaded", async() => {
7676

7777
if (networkNavigation.currentNodeParams !== null) {
7878
window.navigation.setNavByName("network--view");
79-
nsn.neighbourHighlight(currentNodeParams);
80-
updateShowInfoMenu(currentNodeParams);
79+
nsn.neighbourHighlight(networkNavigation.currentNodeParams);
80+
updateShowInfoMenu(networkNavigation.currentNodeParams);
8181
}
8282
});
8383

workspaces/vis-network/src/network.js

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -142,10 +142,10 @@ export default class NodeSecureNetwork {
142142
* @returns {boolean}
143143
*/
144144
focusNodeByNameAndVersion(packageName, version) {
145-
if (!version || !version.trim()){
145+
if (!version || !version.trim()) {
146146
return this.focusNodeByName(packageName);
147147
}
148-
148+
149149
let wantedId = null;
150150
for (const [id, opt] of this.linker) {
151151
if (opt.name === packageName && opt.version === version) {
@@ -203,7 +203,7 @@ export default class NodeSecureNetwork {
203203
const allEdges = this.edges.get();
204204

205205
// reset all edge labels - even if user clicks on empty space
206-
for(let id = 0; id < allEdges.length; id++) {
206+
for (let id = 0; id < allEdges.length; id++) {
207207
Object.assign(allEdges[id], CONSTANTS.LABELS.NONE);
208208
}
209209

@@ -244,17 +244,18 @@ export default class NodeSecureNetwork {
244244
const connectedEdges = this.network.getConnectedEdges(selectedNode);
245245
this.network.selectEdges(connectedEdges);
246246
for (let id = 0; id < connectedEdges.length; id++) {
247-
const edgeIndex = allEdges.findIndex(edge => edge.id === connectedEdges[id]);
247+
const edgeIndex = allEdges.findIndex((edge) => edge.id === connectedEdges[id]);
248248
// the arrow on the edge is set to point into the 'from' node
249-
if(allEdges[edgeIndex].from === selectedNode) {
249+
if (allEdges[edgeIndex].from === selectedNode) {
250250
Object.assign(allEdges[edgeIndex], CONSTANTS.LABELS.INCOMING);
251-
} else if(allEdges[edgeIndex].to === selectedNode){
251+
}
252+
else if (allEdges[edgeIndex].to === selectedNode) {
252253
Object.assign(allEdges[edgeIndex], CONSTANTS.LABELS.OUTGOING);
253-
}
254+
}
254255
}
255256

256257
// offset set to 250 to compensate for the package info slide in on the left of screen
257-
this.network.focus(selectedNode, { animation: true, scale: 0.35, offset: { x:250, y:0 }});
258+
this.network.focus(selectedNode, { animation: true, scale: 0.35, offset: { x: 250, y: 0 } });
258259
}
259260
else if (this.highlightEnabled) {
260261
this.highlightEnabled = false;

0 commit comments

Comments
 (0)