feat(ws): allow to remove packages from availables list (#468)

Author: PierreDemailly

src/cache.js

@@ -156,7 +156,7 @@ class _AppCache {
   }
 
   removePayload(pkg) {
-    fs.rmSync(path.join(kPayloadsPath, pkg.replaceAll("/", "-")), { force: true });
+    fs.rmSync(path.join(kPayloadsPath, pkg.replaceAll("/", kSlashReplaceToken)), { force: true });
   }
 
   async removeLastMRU() {

src/http-server/websocket/commands/remove.js

@@ -4,11 +4,33 @@ export async function* remove(
 ) {
   const { cache, logger } = context;
 
-  const formattedPkg = pkg.replace("/", "-");
-  logger.info(`[ws|remove](pkg: ${pkg}|formatted: ${formattedPkg})`);
+  logger.info(`[ws|remove](pkg: ${pkg})`);
 
   try {
     const { mru, lru, current, lastUsed, root, availables } = await cache.payloadsList();
+    if (availables.includes(pkg)) {
+      logger.info(`[ws|remove] remove from availables`);
+      cache.removePayload(pkg);
+      const updatedList = {
+        mru,
+        lru,
+        lastUsed: {
+          ...lastUsed,
+          [pkg]: void 0
+        },
+        root,
+        availables: availables.filter((pkgName) => pkgName !== pkg)
+      };
+      await cache.updatePayloadsList(updatedList);
+
+      yield {
+        status: "RELOAD",
+        ...updatedList
+      };
+
+      return;
+    }
+
     logger.debug(`[ws|remove](lru: ${lru}|current: ${current})`);
 
     if (mru.length === 1 && lru.length === 0) {
@@ -77,7 +99,7 @@ export async function* remove(
       };
     }
 
-    cache.removePayload(formattedPkg);
+    cache.removePayload(pkg);
   }
   catch (error) {
     logger.error(`[ws|remove](error: ${error.message})`);

test/cache.test.js

@@ -201,7 +201,7 @@ describe("appCache", () => {
 
     appCache.removePayload("foo/bar");
 
-    assert.equal(removedPath, path.join(kPayloadsPath, "foo-bar"));
+    assert.equal(removedPath, path.join(kPayloadsPath, "foo______bar"));
   });
 
   it("should not remove the last MRU when MRU is not full", async(t) => {