fix: detect undefined & null value

fraxken · fraxken · commit f76d5bbfa6a7 · 2023-12-04T17:17:06.000+01:00
diff --git a/public/components/package/pannels/overview/overview.js b/public/components/package/pannels/overview/overview.js
@@ -119,7 +119,7 @@ export class Overview {
     const fragment = document.createDocumentFragment();
 
     const { homepage } = this.package.links;
-    if (homepage.href !== null) {
+    if (typeof homepage.href === "string") {
       fragment.appendChild(utils.createLiField("Homepage", homepage.href, { isLink: true }));
     }
     fragment.appendChild(utils.createLiField("Author", this.author));

Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ export class Overview {`
`119`	`119`	`const fragment = document.createDocumentFragment();`
`120`	`120`
`121`	`121`	`const { homepage } = this.package.links;`
`122`		`- if (homepage.href !== null) {`
	`122`	`+ if (typeof homepage.href === "string") {`
`123`	`123`	`fragment.appendChild(utils.createLiField("Homepage", homepage.href, { isLink: true }));`
`124`	`124`	`}`
`125`	`125`	`fragment.appendChild(utils.createLiField("Author", this.author));`