fix: wait for JOIN confirmations concurrently to avoid missed 366 replies

The sequential wait_for loop would miss the 366 (RPL_ENDOFNAMES) for
later channels because their replies arrived while still waiting on the
first channel.

Author: Pyker

irc_handlers/err_nomotd_422.py

@@ -1,3 +1,4 @@
+import asyncio
 import logging
 
 ID = "422"
@@ -10,14 +11,19 @@ async def execute(self, send_msg, prefix, command, params):
     logger.info("No MOTD (422), starting post-connection setup")
     await self.join_channel(send_msg, self.channels)
 
-    for chan in self.channels:
-        try:
-            await self.wait_for(
+    results = await asyncio.gather(
+        *(
+            self.wait_for(
                 "366",
                 check=lambda p, c, params, ch=chan: ch.lower() in params.lower(),
                 timeout=30,
             )
-        except TimeoutError:
+            for chan in self.channels
+        ),
+        return_exceptions=True,
+    )
+    for chan, result in zip(self.channels, results):
+        if isinstance(result, TimeoutError):
             logger.warning("Timed out waiting for JOIN confirmation on %s", chan)
 
     await send_msg("MODE " + ",".join(self.channels), 4)

irc_handlers/rpl_endofmotd_376.py

@@ -11,14 +11,19 @@ async def execute(self, send_msg, prefix, command, params):
     logger.info("End of MOTD, starting post-connection setup")
     await self.join_channel(send_msg, self.channels)
 
-    for chan in self.channels:
-        try:
-            await self.wait_for(
+    results = await asyncio.gather(
+        *(
+            self.wait_for(
                 "366",
                 check=lambda p, c, params, ch=chan: ch.lower() in params.lower(),
                 timeout=30,
             )
-        except TimeoutError:
+            for chan in self.channels
+        ),
+        return_exceptions=True,
+    )
+    for chan, result in zip(self.channels, results):
+        if isinstance(result, TimeoutError):
             logger.warning("Timed out waiting for JOIN confirmation on %s", chan)
 
     await send_msg("MODE " + ",".join(self.channels), 4)