Skip to content

Commit 54fb5dc

Browse files
committed
Fix baseline + remove TracingPoint when window is closed
1 parent 7b0abbf commit 54fb5dc

3 files changed

Lines changed: 81 additions & 58 deletions

File tree

Lines changed: 64 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -1,57 +1,64 @@
1-
Class {
2-
#name : 'BaselineOfExecutableRequirements',
3-
#superclass : 'BaselineOf',
4-
#category : 'BaselineOfExecutableRequirements',
5-
#package : 'BaselineOfExecutableRequirements'
6-
}
7-
8-
{ #category : 'baselines' }
9-
BaselineOfExecutableRequirements >> baseline: spec [
10-
"Common baseline for all Pharo versions"
11-
12-
<baseline>
13-
spec for: #common do: [ self baselineForCommon: spec ]
14-
]
15-
16-
{ #category : 'baselines' }
17-
BaselineOfExecutableRequirements >> baselineForCommon: spec [
18-
19-
<baseline>
20-
spec preLoadDoIt: #preload:package:.
21-
spec postLoadDoIt: #postload:package:.
22-
23-
"Dependencies"
24-
self coreDependencies: spec.
25-
26-
"Packages"
27-
self corePackages: spec
28-
]
29-
30-
{ #category : 'baselines' }
31-
BaselineOfExecutableRequirements >> coreDependencies: spec [
32-
33-
"No dependencies"
34-
]
35-
36-
{ #category : 'baselines' }
37-
BaselineOfExecutableRequirements >> corePackages: spec [
38-
39-
spec package: 'ExecutableRequirements'.
40-
41-
"tests packages"
42-
spec package: 'ExecutableRequirements-Tests' with: [ spec requires: #( 'ExecutableRequirements' ) ]
43-
]
44-
45-
{ #category : 'baselines' }
46-
BaselineOfExecutableRequirements >> postload: loader package: packageSpec [
47-
"do nothing"
48-
49-
50-
]
51-
52-
{ #category : 'baselines' }
53-
BaselineOfExecutableRequirements >> preload: loader package: packageSpec [
54-
"do nothing"
55-
56-
57-
]
1+
Class {
2+
#name : 'BaselineOfExecutableRequirements',
3+
#superclass : 'BaselineOf',
4+
#category : 'BaselineOfExecutableRequirements',
5+
#package : 'BaselineOfExecutableRequirements'
6+
}
7+
8+
{ #category : 'baselines' }
9+
BaselineOfExecutableRequirements >> baseline: spec [
10+
"Common baseline for all Pharo versions"
11+
12+
<baseline>
13+
spec for: #common do: [ self baselineForCommon: spec ]
14+
]
15+
16+
{ #category : 'baselines' }
17+
BaselineOfExecutableRequirements >> baselineForCommon: spec [
18+
19+
<baseline>
20+
spec preLoadDoIt: #preload:package:.
21+
spec postLoadDoIt: #postload:package:.
22+
23+
"Dependencies"
24+
self coreDependencies: spec.
25+
26+
"Packages"
27+
self corePackages: spec
28+
]
29+
30+
{ #category : 'baselines' }
31+
BaselineOfExecutableRequirements >> coreDependencies: spec [
32+
33+
"No dependencies"
34+
]
35+
36+
{ #category : 'baselines' }
37+
BaselineOfExecutableRequirements >> corePackages: spec [
38+
39+
spec package: 'ExecutableRequirements'.
40+
41+
spec
42+
package: 'ExecutableRequirements-Examples'
43+
with: [ spec requires: #( 'ExecutableRequirements' ) ].
44+
spec
45+
package: 'ExecutableRequirements-Tests'
46+
with: [ spec requires: #( 'ExecutableRequirements' ) ].
47+
spec
48+
package: 'ExecutableRequirements-UI'
49+
with: [ spec requires: #( 'ExecutableRequirements' ) ]
50+
]
51+
52+
{ #category : 'baselines' }
53+
BaselineOfExecutableRequirements >> postload: loader package: packageSpec [
54+
"do nothing"
55+
56+
57+
]
58+
59+
{ #category : 'baselines' }
60+
BaselineOfExecutableRequirements >> preload: loader package: packageSpec [
61+
"do nothing"
62+
63+
64+
]
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Package { #name : 'BaselineOfExecutableRequirements' }
1+
Package { #name : 'BaselineOfExecutableRequirements' }

src/ExecutableRequirements-UI/ExReqUIPresenter.class.st

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ ExReqUIPresenter >> defaultLayout [
3636
yourself
3737
]
3838

39+
{ #category : 'as yet unclassified' }
40+
ExReqUIPresenter >> ensureAllTracingPointsAreRemoved [
41+
42+
self repositoryReport ifNil: [ ^ self ].
43+
self repositoryReport removeTracingPoints
44+
]
45+
3946
{ #category : 'initialization - deprecated' }
4047
ExReqUIPresenter >> initializePresenter [
4148

@@ -58,6 +65,15 @@ ExReqUIPresenter >> isRefreshOnGoing: anObject [
5865
isRefreshOnGoing := anObject
5966
]
6067

68+
{ #category : 'showing' }
69+
ExReqUIPresenter >> open [
70+
71+
| window |
72+
window := super open.
73+
window whenWillCloseDo: [ self ensureAllTracingPointsAreRemoved ].
74+
^ window
75+
]
76+
6177
{ #category : 'accessing' }
6278
ExReqUIPresenter >> refreshIcons [
6379

0 commit comments

Comments
 (0)