Skip to content

[19.0] [IMP] endpoint: support cors setting #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ivantodorovich wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Open

[19.0] [IMP] endpoint: support cors setting #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions endpoint/tests/test_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ def test_routing(self):
"methods": ["GET"],
"routes": ["/demo/one"],
"type": "http",
"cors": "*",
"csrf": False,
"readonly": False,
},
Expand All @@ -161,6 +162,7 @@ def test_routing(self):
"methods": ["POST"],
"routes": ["/new/one"],
"type": "http",
"cors": "*",
"csrf": False,
"readonly": False,
},
Expand All @@ -176,6 +178,7 @@ def test_routing(self):
"methods": ["POST"],
"routes": ["/foo/new/one"],
"type": "http",
"cors": "*",
"csrf": False,
"readonly": False,
},
Expand Down
1 change: 1 addition & 0 deletions endpoint/views/endpoint_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@
required="request_method in ('POST', 'PUT')"
invisible="request_method not in ('POST', 'PUT')"
/>
<field name="cors" />
</group>
</group>
</page>
Expand Down
2 changes: 2 additions & 0 deletions endpoint_route_handler/models/endpoint_route_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ class EndpointRouteHandler(models.AbstractModel):
endpoint_hash = fields.Char(
compute="_compute_endpoint_hash", help="Identify the route with its main params"
)
cors = fields.Char(help="Comma-separated list of allowed origins", default="*")
csrf = fields.Boolean(default=False)
readonly = fields.Boolean(default=False)

Expand Down Expand Up @@ -248,6 +249,7 @@ def _get_routing_info(self):
auth=self.auth_type,
methods=[self.request_method],
routes=[route],
cors=self.cors,
csrf=self.csrf,
readonly=self.readonly,
)
Expand Down
Loading