Skip to content

Commit 141c939

Browse files
Qinglang Miaogregkh
authored andcommitted
drm/lima: fix reference leak in lima_pm_busy
[ Upstream commit de4248b ] pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to putting operation will result in a reference leak here. A new function pm_runtime_resume_and_get is introduced in [0] to keep usage counter balanced. So We fix the reference leak by replacing it with new function. [0] commit dd8088d ("PM: runtime: Add pm_runtime_resume_and_get to deal with usage counter") Fixes: 50de2e9 ("drm/lima: enable runtime pm") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> Signed-off-by: Qiang Yu <yuq825@gmail.com> Link: https://patchwork.freedesktop.org/patch/msgid/20201127094438.121003-1-miaoqinglang@huawei.com (cherry picked from commit de49978) Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent c377925 commit 141c939

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/lima/lima_sched.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ static int lima_pm_busy(struct lima_device *ldev)
200200
int ret;
201201

202202
/* resume GPU if it has been suspended by runtime PM */
203-
ret = pm_runtime_get_sync(ldev->dev);
203+
ret = pm_runtime_resume_and_get(ldev->dev);
204204
if (ret < 0)
205205
return ret;
206206

0 commit comments

Comments
 (0)