PM / devfreq: Add missing error code in devfreq_add_device()

YueHaibing · chanwoochoi · commit 18b380ed61f8 · 2021-05-20T12:16:41.000+09:00
Set err code in the error path before jumping to the end of the function. Fixes: 4dc3bab ("PM / devfreq: Add support delayed timer for polling mode") Signed-off-by: YueHaibing <yuehaibing@huawei.com> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
@@ -823,6 +823,7 @@ struct devfreq *devfreq_add_device(struct device *dev,
 	if (devfreq->profile->timer < 0
 		|| devfreq->profile->timer >= DEVFREQ_TIMER_NUM) {
 		mutex_unlock(&devfreq->lock);
+		err = -EINVAL;
 		goto err_dev;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -823,6 +823,7 @@ struct devfreq devfreq_add_device(struct device dev,`
`823`	`823`	`if (devfreq->profile->timer < 0`
`824`	`824`	`\|\| devfreq->profile->timer >= DEVFREQ_TIMER_NUM) {`
`825`	`825`	`mutex_unlock(&devfreq->lock);`
	`826`	`+ err = -EINVAL;`
`826`	`827`	`goto err_dev;`
`827`	`828`	`}`
`828`	`829`