opp: remove WARN when no valid OPPs remain

osctobe · gregkh · commit 3dea93159038 · 2021-09-03T10:09:26.000+02:00
[ Upstream commit 335ffab ] This WARN can be triggered per-core and the stack trace is not useful. Replace it with plain dev_err(). Fix a comment while at it. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
@@ -870,8 +870,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table)
 		}
 	}
 
-	/* There should be one of more OPP defined */
-	if (WARN_ON(!count)) {
+	/* There should be one or more OPPs defined */
+	if (!count) {
+		dev_err(dev, "%s: no supported OPPs", __func__);
 		ret = -ENOENT;
 		goto remove_static_opp;
 	}

Original file line number	Diff line number	Diff line change
`@@ -870,8 +870,9 @@ static int _of_add_opp_table_v2(struct device dev, struct opp_table opp_table)`
`870`	`870`	`}`
`871`	`871`	`}`
`872`	`872`
`873`		`- /* There should be one of more OPP defined */`
`874`		`- if (WARN_ON(!count)) {`
	`873`	`+ /* There should be one or more OPPs defined */`
	`874`	`+ if (!count) {`
	`875`	`+ dev_err(dev, "%s: no supported OPPs", __func__);`
`875`	`876`	`ret = -ENOENT;`
`876`	`877`	`goto remove_static_opp;`
`877`	`878`	`}`