net: atlantic: Define aq_pm_ops conditionally on CONFIG_PM

Tom Rix · davem330 · commit 4f163bf82b02 · 2023-05-01T07:38:47.000+01:00
For s390, gcc with W=1 reports
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c:458:32: error:
  'aq_pm_ops' defined but not used [-Werror=unused-const-variable=]
  458 | static const struct dev_pm_ops aq_pm_ops = {
      |                                ^~~~~~~~~

The only use of aq_pm_ops is conditional on CONFIG_PM.
The definition of aq_pm_ops and its functions should also
be conditional on CONFIG_PM.

Signed-off-by: Tom Rix &lt;trix@redhat.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c b/drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
@@ -379,6 +379,7 @@ static void aq_pci_shutdown(struct pci_dev *pdev)
 	}
 }
 
+#ifdef CONFIG_PM
 static int aq_suspend_common(struct device *dev)
 {
 	struct aq_nic_s *nic = pci_get_drvdata(to_pci_dev(dev));
@@ -463,6 +464,7 @@ static const struct dev_pm_ops aq_pm_ops = {
 	.restore = aq_pm_resume_restore,
 	.thaw = aq_pm_thaw,
 };
+#endif
 
 static struct pci_driver aq_pci_ops = {
 	.name = AQ_CFG_DRV_NAME,

Original file line number	Diff line number	Diff line change
`@@ -379,6 +379,7 @@ static void aq_pci_shutdown(struct pci_dev *pdev)`
`379`	`379`	`}`
`380`	`380`	`}`
`381`	`381`
	`382`	`+#ifdef CONFIG_PM`
`382`	`383`	`static int aq_suspend_common(struct device *dev)`
`383`	`384`	`{`
`384`	`385`	`struct aq_nic_s *nic = pci_get_drvdata(to_pci_dev(dev));`
`@@ -463,6 +464,7 @@ static const struct dev_pm_ops aq_pm_ops = {`
`463`	`464`	`.restore = aq_pm_resume_restore,`
`464`	`465`	`.thaw = aq_pm_thaw,`
`465`	`466`	`};`
	`467`	`+#endif`
`466`	`468`
`467`	`469`	`static struct pci_driver aq_pci_ops = {`
`468`	`470`	`.name = AQ_CFG_DRV_NAME,`