Skip to content

Commit 6ebb685

Browse files
Chunfeng Yungregkh
authored andcommitted
usb: mtu3: fix interval value for intr and isoc
[ Upstream commit e3d4621 ] Use the Interval value from isoc/intr endpoint descriptor, no need minus one. The original code doesn't cause transfer error for normal cases, but it may have side effect with respond time of ERDY or tPingTimeout. Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com> Link: https://lore.kernel.org/r/20211218095749.6250-1-chunfeng.yun@mediatek.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 12a4c10 commit 6ebb685

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/usb/mtu3/mtu3_gadget.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep)
7777
if (usb_endpoint_xfer_int(desc) ||
7878
usb_endpoint_xfer_isoc(desc)) {
7979
interval = desc->bInterval;
80-
interval = clamp_val(interval, 1, 16) - 1;
80+
interval = clamp_val(interval, 1, 16);
8181
if (usb_endpoint_xfer_isoc(desc) && comp_desc)
8282
mult = comp_desc->bmAttributes;
8383
}
@@ -89,7 +89,7 @@ static int mtu3_ep_enable(struct mtu3_ep *mep)
8989
if (usb_endpoint_xfer_isoc(desc) ||
9090
usb_endpoint_xfer_int(desc)) {
9191
interval = desc->bInterval;
92-
interval = clamp_val(interval, 1, 16) - 1;
92+
interval = clamp_val(interval, 1, 16);
9393
mult = usb_endpoint_maxp_mult(desc) - 1;
9494
}
9595
break;

0 commit comments

Comments
 (0)