Skip to content

Commit 75eb690

Browse files
Saaem Rizvigregkh
authored andcommitted
drm/amd/display: Remove OTG DIV register write for Virtual signals.
[ Upstream commit 709671f ] [WHY] Hot plugging and then hot unplugging leads to k1 and k2 values to change, as signal is detected as a virtual signal on hot unplug. Writing these values to OTG_PIXEL_RATE_DIV register might cause primary display to blank (known hw bug). [HOW] No longer write k1 and k2 values to register if signal is virtual, we have safe guards in place in the case that k1 and k2 is unassigned so that an unknown value is not written to the register either. Cc: stable@vger.kernel.org Cc: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Samson Tam <Samson.Tam@amd.com> Reviewed-by: Alvin Lee <Alvin.Lee2@amd.com> Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com> Signed-off-by: Saaem Rizvi <SyedSaaem.Rizvi@amd.com> Tested-by: Daniel Wheeler <daniel.wheeler@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 0ac86f7 commit 75eb690

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/gpu/drm/amd/display/dc/dcn32/dcn32_hwseq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1180,7 +1180,7 @@ unsigned int dcn32_calculate_dccg_k1_k2_values(struct pipe_ctx *pipe_ctx, unsign
11801180
*k2_div = PIXEL_RATE_DIV_BY_2;
11811181
else
11821182
*k2_div = PIXEL_RATE_DIV_BY_4;
1183-
} else if (dc_is_dp_signal(stream->signal) || dc_is_virtual_signal(stream->signal)) {
1183+
} else if (dc_is_dp_signal(stream->signal)) {
11841184
if (two_pix_per_container) {
11851185
*k1_div = PIXEL_RATE_DIV_BY_1;
11861186
*k2_div = PIXEL_RATE_DIV_BY_2;

0 commit comments

Comments
 (0)