Skip to content

Commit a958d14

Browse files
Marek Vasutgregkh
authored andcommitted
video: backlight: Drop maximum brightness override for brightness zero
commit 33a5471 upstream. The note in c2adda2 ("video: backlight: Add of_find_backlight helper in backlight.c") says that gpio-backlight uses brightness as power state. This has been fixed since in ec665b7 ("backlight: gpio-backlight: Correct initial power state handling") and other backlight drivers do not require this workaround. Drop the workaround. This fixes the case where e.g. pwm-backlight can perfectly well be set to brightness 0 on boot in DT, which without this patch leads to the display brightness to be max instead of off. Fixes: c2adda2 ("video: backlight: Add of_find_backlight helper in backlight.c") Cc: <stable@vger.kernel.org> # 5.4+ Cc: <stable@vger.kernel.org> # 4.19.x: ec665b7: backlight: gpio-backlight: Correct initial power state handling Signed-off-by: Marek Vasut <marex@denx.de> Acked-by: Noralf Trønnes <noralf@tronnes.org> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Signed-off-by: Lee Jones <lee.jones@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent d9dad32 commit a958d14

1 file changed

Lines changed: 0 additions & 6 deletions

File tree

drivers/video/backlight/backlight.c

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -688,12 +688,6 @@ static struct backlight_device *of_find_backlight(struct device *dev)
688688
of_node_put(np);
689689
if (!bd)
690690
return ERR_PTR(-EPROBE_DEFER);
691-
/*
692-
* Note: gpio_backlight uses brightness as
693-
* power state during probe
694-
*/
695-
if (!bd->props.brightness)
696-
bd->props.brightness = bd->props.max_brightness;
697691
}
698692
}
699693

0 commit comments

Comments
 (0)