Skip to content

Commit d89a80e

Browse files
Furong Xugregkh
authored andcommitted
net: stmmac: xgmac: fix a typo of register name in DPP safety handling
commit 1ce2654 upstream. DDPP is copied from Synopsys Data book: DDPP: Disable Data path Parity Protection. When it is 0x0, Data path Parity Protection is enabled. When it is 0x1, Data path Parity Protection is disabled. The macro name should be XGMAC_DPP_DISABLE. Fixes: 46eba19 ("net: stmmac: xgmac: fix handling of DPP safety error for DMA channels") Signed-off-by: Furong Xu <0x1207@gmail.com> Reviewed-by: Serge Semin <fancer.lancer@gmail.com> Link: https://lore.kernel.org/r/20240203053133.1129236-1-0x1207@gmail.com Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7b430fb commit d89a80e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/net/ethernet/stmicro/stmmac/dwxgmac2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@
283283
#define XGMAC_TXCEIE BIT(0)
284284
#define XGMAC_MTL_ECC_INT_STATUS 0x000010cc
285285
#define XGMAC_MTL_DPP_CONTROL 0x000010e0
286-
#define XGMAC_DDPP_DISABLE BIT(0)
286+
#define XGMAC_DPP_DISABLE BIT(0)
287287
#define XGMAC_MTL_TXQ_OPMODE(x) (0x00001100 + (0x80 * (x)))
288288
#define XGMAC_TQS GENMASK(25, 16)
289289
#define XGMAC_TQS_SHIFT 16

drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -886,7 +886,7 @@ dwxgmac3_safety_feat_config(void __iomem *ioaddr, unsigned int asp,
886886
/* 5. Enable Data Path Parity Protection */
887887
value = readl(ioaddr + XGMAC_MTL_DPP_CONTROL);
888888
/* already enabled by default, explicit enable it again */
889-
value &= ~XGMAC_DDPP_DISABLE;
889+
value &= ~XGMAC_DPP_DISABLE;
890890
writel(value, ioaddr + XGMAC_MTL_DPP_CONTROL);
891891

892892
return 0;

0 commit comments

Comments
 (0)