Skip to content

Commit e750620

Browse files
popcornmixgregkh
authored andcommitted
drm/vc4: hdmi: Move hdmi reset to bind
[ Upstream commit 902dc5c ] The hdmi reset got moved to a later point in the commit 9045e91 ("drm/vc4: hdmi: Add reset callback"). However, the reset now occurs after vc4_hdmi_cec_init and so tramples the setup of registers like HDMI_CEC_CNTRL_1 This only affects pi0-3 as on pi4 the cec registers are in a separate block Fixes: 9045e91 ("drm/vc4: hdmi: Add reset callback") Reviewed-by: Dave Stevenson <dave.stevenson@raspberrypi.com> Signed-off-by: Dom Cobley <popcornmix@gmail.com> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Tested-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Link: https://patchwork.freedesktop.org/patch/msgid/20210111142309.193441-3-maxime@cerno.tech (cherry picked from commit 7155334) Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent f06ce8d commit e750620

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

drivers/gpu/drm/vc4/vc4_hdmi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -661,9 +661,6 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder)
661661
return;
662662
}
663663

664-
if (vc4_hdmi->variant->reset)
665-
vc4_hdmi->variant->reset(vc4_hdmi);
666-
667664
if (vc4_hdmi->variant->phy_init)
668665
vc4_hdmi->variant->phy_init(vc4_hdmi, mode);
669666

@@ -1744,6 +1741,9 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
17441741
vc4_hdmi->disable_wifi_frequencies =
17451742
of_property_read_bool(dev->of_node, "wifi-2.4ghz-coexistence");
17461743

1744+
if (vc4_hdmi->variant->reset)
1745+
vc4_hdmi->variant->reset(vc4_hdmi);
1746+
17471747
pm_runtime_enable(dev);
17481748

17491749
drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS);

0 commit comments

Comments
 (0)