Skip to content

Commit 6eb4650

Browse files
committed
TEDEFO-3325 addressing feedback to change from debug to trace and improving the logs.
1 parent 4b26731 commit 6eb4650

2 files changed

Lines changed: 7 additions & 16 deletions

File tree

src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentDescriptor.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ public T createInstance(Object... initArgs) throws InstantiationException {
5050
.collect(Collectors.toList())
5151
.toArray(new Class[0]);
5252

53-
logger.debug("Creating an instance of [{}] using constructor with parameter types: {}",
53+
logger.trace("Creating an instance of [{}] using constructor with parameter types: {}",
5454
implType, paramTypes);
5555

5656
Constructor<T> constructor = Optional

src/main/java/eu/europa/ted/eforms/sdk/component/SdkComponentFactory.java

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -80,18 +80,10 @@ private void populateComponents() {
8080
.map(Package::getName)
8181
.toArray(String[]::new);
8282

83-
if (logger.isDebugEnabled()) {
83+
if (logger.isTraceEnabled()) {
8484
final List<String> packages = Arrays.asList(availablePackages);
85-
86-
logger.debug("eforms eu packages:");
87-
packages.stream().sorted()
88-
.filter(p -> p.contains("eu.") && !p.contains("digit"))
89-
.forEach(p -> logger.debug(p));
90-
91-
logger.debug("viewer package");
9285
packages.stream().sorted()
93-
.filter(p -> p.contains("eu.europa.ted.eforms.viewer"))
94-
.forEach(p -> logger.debug(p));
86+
.forEach(p -> logger.trace(p));
9587
}
9688

9789
new Reflections(ConfigurationBuilder.build().forPackages(availablePackages))
@@ -154,12 +146,12 @@ protected <T> T getComponentImpl(String sdkVersion, final SdkComponentType compo
154146
.orElseGet(Collections::emptyMap);
155147

156148
if (logger.isDebugEnabled()) {
157-
logger.debug("selector componentType={}", selector.componentType);
158-
logger.debug("selector qualifier={}", selector.qualifier);
159-
logger.debug("normalized version={}", normalizedVersion);
149+
logger.debug("Looking for component with version=[{}], componentType=[{}], qualifier=[{}]",
150+
normalizedVersion, selector.componentType, selector.qualifier);
160151
for (Entry<ComponentSelector, SdkComponentDescriptor<?>> entry : map.entrySet()) {
161152
logger.debug(
162-
"entry key componentType={}, key qualifier={}, value={}",
153+
"Available component for this version: "
154+
+ "componentType=[{}], qualifier=[{}], value=[{}]",
163155
entry.getKey().componentType,
164156
entry.getKey().qualifier,
165157
entry.getValue().getImplType().getName());
@@ -169,7 +161,6 @@ protected <T> T getComponentImpl(String sdkVersion, final SdkComponentType compo
169161
@SuppressWarnings("unchecked")
170162
SdkComponentDescriptor<T> descriptor =
171163
(SdkComponentDescriptor<T>) map.get(selector);
172-
logger.debug("descriptor descriptor={}", descriptor);
173164

174165
if (descriptor == null) {
175166
logger.error("Failed to load required components of SDK [{}]", sdkVersion);

0 commit comments

Comments
 (0)