Refactor: Rename getSdkNoticeType to getSdkNoticeSubtype and update variable names

Author: rousso

src/main/java/eu/europa/ted/eforms/sdk/entity/SdkEntityFactory.java

@@ -31,7 +31,7 @@ public static SdkNode getSdkNode(String sdkVersion, JsonNode node) throws Instan
         SdkNode.class, node);
   }
 
-  public static SdkNoticeSubtype getSdkNoticeType(final String sdkVersion, final JsonNode json)
+  public static SdkNoticeSubtype getSdkNoticeSubtype(final String sdkVersion, final JsonNode json)
       throws InstantiationException {
     return SdkEntityFactory.INSTANCE.getComponentImpl(sdkVersion, SdkComponentType.NOTICE_TYPE,
         SdkNoticeSubtype.class, json);

src/main/java/eu/europa/ted/eforms/sdk/repository/SdkNoticeTypeRepository.java

@@ -20,10 +20,10 @@ public SdkNoticeTypeRepository(String sdkVersion, Path jsonPath) throws Instanti
 
   @Override
   protected void populateMap(final JsonNode json) throws InstantiationException {
-    final ArrayNode noticeTypes = (ArrayNode) json.get(SdkConstants.NOTICE_TYPES_JSON_SUBTYPES_KEY);
-    for (final JsonNode noticeType : noticeTypes) {
-      final SdkNoticeSubtype sdkNoticeType = SdkEntityFactory.getSdkNoticeType(sdkVersion, noticeType);
-      put(sdkNoticeType.getId(), sdkNoticeType);
+    final ArrayNode noticeSubtypes = (ArrayNode) json.get(SdkConstants.NOTICE_TYPES_JSON_SUBTYPES_KEY);
+    for (final JsonNode noticeSubtype : noticeSubtypes) {
+      final SdkNoticeSubtype sdkNoticeSubtype = SdkEntityFactory.getSdkNoticeSubtype(sdkVersion, noticeSubtype);
+      put(sdkNoticeSubtype.getId(), sdkNoticeSubtype);
     }
   }
 }