Remove duplicate GDS type registration commit in server startup path (#3676)

Copilot · marcschier · web-flow · commit 6ee858d0baae · 2026-04-19T16:25:26.000+02:00
* Initial plan * Remove duplicate GDS type registration and add startup coverage test Agent-Logs-Url: https://github.com/OPCFoundation/UA-.NETStandard/sessions/86388b62-268b-4598-ab31-ddd820d414dc Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: marcschier <11168470+marcschier@users.noreply.github.com>
diff --git a/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs b/Libraries/Opc.Ua.Gds.Server.Common/ApplicationsNodeManager.cs
@@ -137,7 +137,6 @@ public ApplicationsNodeManager(
                 m_logger.LogInformation("Database Initialized!");
             }
 
-            Server.MessageContext.Factory.Builder.AddOpcUaGds().Commit();
         }
 
         /// <summary>
diff --git a/Tests/Opc.Ua.Gds.Tests/CustomCertificateGroupIntegrationTest.cs b/Tests/Opc.Ua.Gds.Tests/CustomCertificateGroupIntegrationTest.cs
@@ -96,6 +96,13 @@ public async Task OneTimeTearDownAsync()
             }
         }
 
+        [Test]
+        public void ServerRegistersGdsEncodeableTypesOnStartup()
+        {
+            Assert.That(m_server.Server.MessageContext.Factory.ContainsEncodeableType(
+                DataTypeIds.ApplicationRecordDataType), Is.True);
+        }
+
         [Test]
         public async Task CustomCertificateGroupAppearsInGetCertificateGroupsAsync()
         {

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,6 @@ public ApplicationsNodeManager(`
`137`	`137`	`m_logger.LogInformation("Database Initialized!");`
`138`	`138`	`}`
`139`	`139`
`140`		`- Server.MessageContext.Factory.Builder.AddOpcUaGds().Commit();`
`141`	`140`	`}`
`142`	`141`
`143`	`142`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,13 @@ public async Task OneTimeTearDownAsync()`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
	`99`	`+ [Test]`
	`100`	`+ public void ServerRegistersGdsEncodeableTypesOnStartup()`
	`101`	`+ {`
	`102`	`+ Assert.That(m_server.Server.MessageContext.Factory.ContainsEncodeableType(`
	`103`	`+ DataTypeIds.ApplicationRecordDataType), Is.True);`
	`104`	`+ }`
	`105`	`+`
`99`	`106`	`[Test]`
`100`	`107`	`public async Task CustomCertificateGroupAppearsInGetCertificateGroupsAsync()`
`101`	`108`	`{`