Ace High not Low

[cw-owasp]

Describe the bug

I noticed a navigation inconsistency in the suit/card browser on cornucopia.owasp.org

To Reproduce

1. Expand a suit in any deck/edition
2. The first card in the list is the Ace card
3. Click on that to display the Ace card
4. Then click ">" (next card)
5. The card displayed is the "2" of the following suit - correctly

Expected behavior

Ace is high, so the card browser listing should perhaps start at "2" for each suit and finish on "A" to make it consistent with navigation on these card pages.

Screenshots

[Adarshkumar0509]

hii @cw-owasp, can i take this issue?

[cw-owasp]

I think we should wait and see what others think about it.

[sydseter]

I agree; Placing the Ace last in the list is the easiest fix. Alternatively, we should make sure the aces are placed first in the sorting order. This is how the cards are sorted when printed, but the important part is that the card browser is not confusing to use.

[sydseter]

I think the reason the Ace is sorted last has to do with the YAML file. The Ace is last there, but when you buy a brand-new card deck, the Ace always comes first. It may be more elegant to change the order in the card browser so that the Ace comes first there too. E.g: PCA, PC2, PC3 etc.

[cw-owasp]

I don't mind either way, as long as the displayed list and the previous/next are consistent.

[sydseter]

Practical speaking, same here.

[sydseter]

So either of this is fine then. The person doing the implementing can have a look and see. It would be noce if the Aces came first, as in the list, but if that is hard, the other option is also ok.

[Adarshkumar0509]

In threat dragon I added companion edition there as well Ace was first but https://copi.owasp.org/cards card browser it was starting from 2,3,....,9,A,J,K,Q &10.

[sydseter]

In threat dragon I added companion edition there as well Ace was first but https://copi.owasp.org/cards card browser it was starting from 2,3,....,9,A,J,K,Q &10.

In Threat Dragon it has no real impact on the user experience.

[Mehul01-Max]

Hi @sydseter and @cw-owasp, I'd like to take up this issue if it's still open!

I read through the discussion above, and as suggested, I've implemented the easiest fix: changing the sort order in the sidebar so that the Ace is listed last (making it consistent with the existing < and > navigation arrows, which already treat Ace as high/last based on the YAML files).

The change only required updating the cardOrder map in cornucopia.owasp.org/src/domain/card/order.ts. I've tested it locally, and all tests are passing.

Let me know if you're happy with this approach, and I can open a PR!

[sydseter]

Please comment again if you want to work on this issue.