OXDEV-9497 Rework UserModelFactory test to actually test the code but not a mock

Author: Sieg

src/Extension/Model/User.php

@@ -25,7 +25,7 @@
  *
  * @mixin BaseModel
  */
-class User extends User_parent implements PersonalGreetingUserInterface
+class User extends User_parent implements UserInterface
 {
     use PersonalGreetingUser;
 }

src/Extension/Model/UserInterface.php

@@ -0,0 +1,14 @@
+<?php
+
+/**
+ * Copyright © OXID eSales AG. All rights reserved.
+ * See LICENSE file for license details.
+ */
+
+namespace OxidEsales\ExamplesModule\Extension\Model;
+
+use OxidEsales\ExamplesModule\Greeting\Model\PersonalGreetingUserInterface;
+
+interface UserInterface extends PersonalGreetingUserInterface
+{
+}

src/Greeting/Infrastructure/UserModelFactory.php

@@ -18,6 +18,7 @@ class UserModelFactory implements UserModelFactoryInterface
      */
     public function create(): User
     {
-        return oxNew(User::class); /** @phpstan-ignore return.type */
+        /** @phpstan-ignore return.type */
+        return oxNew(User::class);
     }
 }

tests/Integration/Greeting/Infrastructure/UserModelFactoryTest.php

@@ -0,0 +1,41 @@
+<?php
+
+/**
+ * Copyright © . All rights reserved.
+ * See LICENSE file for license details.
+ */
+
+declare(strict_types=1);
+
+namespace OxidEsales\ExamplesModule\Tests\Unit\Greeting\Infrastructure;
+
+use OxidEsales\ExamplesModule\Extension\Model\UserInterface;
+use OxidEsales\ExamplesModule\Greeting\Infrastructure\UserModelFactory;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+/**
+ * @covers \OxidEsales\ExamplesModule\Greeting\Infrastructure\UserModelFactory
+ */
+class UserModelFactoryTest extends TestCase
+{
+    #[Test]
+    public function createProducesCorrectTypeOfObjects(): void
+    {
+        $sut = new UserModelFactory();
+
+        $user = $sut->create();
+        $this->assertInstanceOf(UserInterface::class, $user);
+    }
+
+    #[Test]
+    public function createProducesNewObjectsWithEveryCall(): void
+    {
+        $sut = new UserModelFactory();
+
+        $user1 = $sut->create();
+        $user2 = $sut->create();
+
+        $this->assertNotSame($user1, $user2);
+    }
+}