OXDEV-9496: Randomize strings and rename "getSut"-method

Author: MarcelOxid

tests/Unit/Greeting/Service/GreetingMessageServiceTest.php

@@ -23,12 +23,12 @@ final class GreetingMessageServiceTest extends TestCase
     public function testGeneralGreeting(): void
     {
         $shopName = uniqid();
-        $service = $this->getGreetingMessageService(
+        $service = $this->getSut(
             shopLanguage: $langStub = $this->createStub(CoreLanguage::class),
             shopName: $shopName,
         );
 
-        $translatedString = 'Welcome to shop %s!';
+        $translatedString = uniqid() . ' %s';
         $langStub->method('translateString')
             ->with(ModuleCore::GENERAL_GREETING_LANGUAGE_CONST)
             ->willReturn($translatedString);
@@ -38,7 +38,7 @@ public function testGeneralGreeting(): void
 
     public function testGenericGreetingNoUserForGenericMode(): void
     {
-        $service = $this->getGreetingMessageService(
+        $service = $this->getSut(
             moduleSettings: $moduleSettingsStub = $this->createMock(ModuleSettingsServiceInterface::class),
             shopLanguage: $langStub = $this->createStub(CoreLanguage::class),
         );
@@ -56,7 +56,7 @@ public function testGenericGreetingNoUserForGenericMode(): void
 
     public function testGenericGreetingWithUserForGenericMode(): void
     {
-        $service = $this->getGreetingMessageService(
+        $service = $this->getSut(
             moduleSettings: $moduleSettingsStub = $this->createMock(ModuleSettingsServiceInterface::class),
             shopLanguage: $langStub = $this->createStub(CoreLanguage::class),
         );
@@ -74,7 +74,7 @@ public function testGenericGreetingWithUserForGenericMode(): void
 
     public function testGenericGreetingNoUserForPersonalMode(): void
     {
-        $service = $this->getGreetingMessageService(
+        $service = $this->getSut(
             moduleSettings: $moduleSettingsStub = $this->createMock(ModuleSettingsServiceInterface::class),
         );
 
@@ -84,7 +84,7 @@ public function testGenericGreetingNoUserForPersonalMode(): void
         $this->assertSame('', $service->getGreeting(null));
     }
 
-    private function getGreetingMessageService(
+    private function getSut(
         ?ModuleSettingsServiceInterface $moduleSettings = null,
         ?CoreRequest $shopRequest = null,
         ?CoreLanguage $shopLanguage = null,
@@ -94,7 +94,7 @@ private function getGreetingMessageService(
             moduleSettings: $moduleSettings ?? $this->createStub(ModuleSettingsServiceInterface::class),
             shopRequest: $shopRequest ?? $this->createStub(CoreRequest::class),
             shopLanguage: $shopLanguage ?? $this->createStub(CoreLanguage::class),
-            shopName: $shopName ?? 'Test Shop',
+            shopName: $shopName ?? uniqid(),
         );
     }
 }