OXDEV-9885 Fix providers visibility tests

Author: NikolaIvanovski

src/Authentication/OAuth2/Service/ModuleSettingsService.php

@@ -58,6 +58,11 @@ public function isGoogleLoginEnabled(): bool
         return $this->moduleSettingService->getBoolean(self::GOOGLE_LOGIN_ENABLED, Module::MODULE_ID);
     }
 
+    public function saveGoogleEnabled(bool $value): void
+    {
+        $this->moduleSettingService->saveBoolean(self::GOOGLE_LOGIN_ENABLED, $value, Module::MODULE_ID);
+    }
+
     public function getGoogleClientId(): string
     {
         return $this->getStringValue(self::GOOGLE_CLIENT_ID);

src/Shared/Core/ViewConfig.php

@@ -52,8 +52,10 @@ public function getImage(): string
         return 'data:image/jpeg;base64,' . base64_encode($images[ImageCaptchaService::CAPTCHA_NAME]);
     }
 
-    public function getProviders(): iterable
+    public function getActiveProviders(): iterable
     {
-        return $this->getService(ProviderCollectorInterface::class)->getProviders();
+        $providers = $this->getService(ProviderCollectorInterface::class)->getProviders();
+
+        return array_filter($providers, fn($provider) => $provider->isActive());
     }
 }

tests/Codeception/Acceptance/BaseCest.php

@@ -40,7 +40,8 @@ protected function setCaptchaState(bool $state)
 
     protected function setProviderState(bool $state)
     {
-        ContainerFacade::get(OAuthModuleSettingsServiceInterface::class)
-            ->saveFacebookEnabled($state);
+        $moduleSettings = ContainerFacade::get(OAuthModuleSettingsServiceInterface::class);
+        $moduleSettings->saveFacebookEnabled($state);
+        $moduleSettings->saveGoogleEnabled($state);
     }
 }

views/twig/form/providers.html.twig

@@ -1,6 +1,6 @@
-{% if oViewConf.getProviders() %}
+{% if oViewConf.getActiveProviders() %}
     <div class="sign-in-providers">
-    {% for provider in oViewConf.getProviders() %}
+    {% for provider in oViewConf.getActiveProviders() %}
         <div class="provider">
             <a href="{{ seo_url({ ident: oViewConf.getSelfLink() ~ "cl=oauth&fnc=login&provider=" ~ provider.getName() }) }}">
                 {{ translate({ ident: 'SIGN_IN_PROVIDER', args: provider.getName()|capitalize }) }}