Skip to content

Commit 50067a5

Browse files
committed
OXDEV-9078 Add todos
1 parent 8d0d2e8 commit 50067a5

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

src/Authentication/TwoFactorAuth/Service/TwoFAUserService.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,9 @@
1515
use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Factory\UserModelFactoryInterface;
1616
use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
1717

18+
/**
19+
* todo-high: challenge the idea - session part should go to the separate login state service
20+
*/
1821
class TwoFAUserService implements TwoFAUserServiceInterface
1922
{
2023
public const USER_SESSION_KEY = 'pending_authorized_user';
@@ -45,6 +48,7 @@ public function loginUser(string $userId): void
4548
{
4649
$this->session->remove(self::USER_SESSION_KEY);
4750

51+
// todo-high: looks like it can go to the infrastructure layer
4852
$user = $this->userFactory->create();
4953
$user->load($userId);
5054

0 commit comments

Comments
 (0)