OXDEV-9078 Reuse what we had for Email notification for the new implementation

Author: Sieg

src/Authentication/TwoFactorAuth/OTP/Notifier/Email/OtpEmailNotifier.php

@@ -9,12 +9,27 @@
 
 namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Notifier\Email;
 
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Factory\EmailFactoryInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Repository\NewUserRepositoryInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Notifier\OtpNotifierInterface;
 
 class OtpEmailNotifier implements OtpNotifierInterface
 {
+    public function __construct(
+        private EmailFactoryInterface $emailFactory,
+        private NewUserRepositoryInterface $userRepository,
+    ) {
+    }
+
     public function notify(string $userId, #[\SensitiveParameter] string $code): void
     {
-        // todo-critical: implement email notifier
+        $email = $this->userRepository->getUserById($userId)->getEmail();
+
+        // todo-critical: load the translations
+        $this->emailFactory->create()->sendEmail(
+            $email,
+            'Your verification code',
+            "Your verification code is: {$code}"
+        );
     }
 }

src/Authentication/TwoFactorAuth/OTP/OtpFacade.php

@@ -44,6 +44,8 @@ public function triggerChallenge(string $userId): void
     {
         $code = $this->codeGenerator->generateCode();
 
+        // todo-critical: check if we can trigger the notification
+
         $this->stateService->createChallengeState($userId, $code);
         $this->notifierFactory->create($userId)->notify($userId, $code);
 

tests/Unit/Authentication/TwoFactorAuth/OTP/Notifier/Email/OtpEmailNotifierTest.php

@@ -0,0 +1,66 @@
+<?php
+
+/**
+ * Copyright © OXID eSales AG. All rights reserved.
+ * See LICENSE file for license details.
+ */
+
+declare(strict_types=1);
+
+namespace OxidEsales\SecurityModule\Tests\Unit\Authentication\TwoFactorAuth\OTP\Notifier\Email;
+
+use OxidEsales\Eshop\Core\Email;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\DTO\NewUserInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Factory\EmailFactoryInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Repository\NewUserRepositoryInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Notifier\Email\OtpEmailNotifier;
+use PHPUnit\Framework\Attributes\Test;
+use PHPUnit\Framework\TestCase;
+
+class OtpEmailNotifierTest extends TestCase
+{
+    #[Test]
+    public function notifySendsEmailToUserAddress(): void
+    {
+        $email = uniqid() . '@example.com';
+        $code = uniqid();
+
+        $userStub = $this->createStub(NewUserInterface::class);
+        $userStub->method('getEmail')->willReturn($email);
+
+        $userRepositoryMock = $this->createMock(NewUserRepositoryInterface::class);
+        $userRepositoryMock->expects($this->once())
+            ->method('getUserById')
+            ->with($userId = uniqid())
+            ->willReturn($userStub);
+
+        $emailModelSpy = $this->createMock(Email::class);
+        $emailModelSpy->expects($this->once())
+            ->method('sendEmail')
+            ->with(
+                $email,
+                'Your verification code',
+                "Your verification code is: {$code}"
+            );
+
+        $emailFactoryStub = $this->createStub(EmailFactoryInterface::class);
+        $emailFactoryStub->method('create')->willReturn($emailModelSpy);
+
+        $sut = $this->getSut(
+            emailFactory: $emailFactoryStub,
+            userRepository: $userRepositoryMock,
+        );
+
+        $sut->notify(userId: $userId, code: $code);
+    }
+
+    private function getSut(
+        EmailFactoryInterface $emailFactory = null,
+        NewUserRepositoryInterface $userRepository = null,
+    ): OtpEmailNotifier {
+        return new OtpEmailNotifier(
+            emailFactory: $emailFactory ?? $this->createStub(EmailFactoryInterface::class),
+            userRepository: $userRepository ?? $this->createStub(NewUserRepositoryInterface::class),
+        );
+    }
+}