OXDEV-9078 Rework middle state case in JsonResponse

Author: Sieg

src/Authentication/TwoFactorAuth/Transput/JsonResponse.php

@@ -13,21 +13,14 @@
 
 class JsonResponse implements JsonResponseInterface
 {
-    private int $statusCode = 200;
-
     public function __construct(
         private readonly Utils $utils
     ) {
     }
 
-    public function setStatusCode(int $code): void
-    {
-        $this->statusCode = $code;
-    }
-
-    public function send(array $data): void
+    public function send(array $data, int $statusCode = 200): void
     {
-        $this->utils->setHeader('HTTP/1.1 ' . $this->statusCode);
+        $this->utils->setHeader('HTTP/1.1 ' . $statusCode);
         $this->utils->setHeader('Content-Type: application/json');
 
         $response = (string) json_encode($data);

src/Authentication/TwoFactorAuth/Transput/JsonResponseInterface.php

@@ -9,7 +9,5 @@
 
 interface JsonResponseInterface
 {
-    public function setStatusCode(int $code): void;
-
-    public function send(array $data): void;
+    public function send(array $data, int $statusCode = 200): void;
 }

tests/Unit/Authentication/TwoFactorAuth/Transput/JsonResponseTest.php

@@ -36,13 +36,12 @@ public function testSendOutputsJsonEncodedData(): void
     {
         $data = ['status' => 'ok', 'code' => 123];
 
-        $utilsMock = $this->createMock(Utils::class);
-        $utilsMock->method('setHeader');
-        $utilsMock->expects($this->once())
+        $utilsSpy = $this->createMock(Utils::class);
+        $utilsSpy->expects($this->once())
             ->method('showMessageAndExit')
             ->with(json_encode($data));
 
-        $sut = new JsonResponse($utilsMock);
+        $sut = new JsonResponse($utilsSpy);
         $sut->send($data);
     }
 
@@ -57,8 +56,7 @@ public function testSendWithCustomStatusCode(): void
         $utilsMock->method('showMessageAndExit');
 
         $sut = new JsonResponse($utilsMock);
-        $sut->setStatusCode(429);
-        $sut->send([]);
+        $sut->send([], 429);
 
         $this->assertContains('HTTP/1.1 429', $headers);
     }