OXDEV-9078 Move user settings service to Settings namespace

Sieg · Sieg · commit c6495ab84ab4 · 2026-04-10T19:01:41.000+03:00
Signed-off-by: Anton Fedurtsya &lt;anton@fedurtsya.com&gt;
diff --git a/metadata.php b/metadata.php
@@ -9,7 +9,7 @@
  * Metadata version
  */
 
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettings as TwoFactorAuthModuleSettings;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettings as TwoFactorAuthModuleSettings;
 use OxidEsales\SecurityModule\PasswordPolicy\Service\ModuleSettingsService as PasswordPolicyModuleSettings;
 use OxidEsales\SecurityModule\Captcha\Service\ModuleSettingsService as CaptchaModuleSettings;
 use OxidEsales\SecurityModule\Authentication\OAuth2\Service\ModuleSettingsService as OAuthModuleSettings;
@@ -171,6 +171,7 @@
             'value' => false
         ],
         [
+            //todo-high: should be moved to the user settings (near by 2FA turning on switch)
             'group' => 'two_factor_auth',
             'name'  => TwoFactorAuthModuleSettings::TWO_FACTOR_TYPE,
             'type'  => 'select',
diff --git a/src/Authentication/TwoFactorAuth/Controller/AccountSecurityController.php b/src/Authentication/TwoFactorAuth/Controller/AccountSecurityController.php
@@ -11,7 +11,7 @@
 
 use OxidEsales\Eshop\Application\Controller\FrontendController;
 use OxidEsales\Eshop\Core\Registry;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserSettingsServiceInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettingsInterface;
 
 class AccountSecurityController extends FrontendController
 {
@@ -22,7 +22,7 @@ class AccountSecurityController extends FrontendController
     protected $_sThisTemplate = '@oe_security_module/templates/account_security';
 
     public function __construct(
-        private readonly TwoFAUserSettingsServiceInterface $userSettingsService,
+        private readonly TwoFAUserSettingsInterface $userSettingsService,
     ) {
         parent::__construct();
     }
diff --git a/src/Authentication/TwoFactorAuth/Factory/TwoFAServiceFactory.php b/src/Authentication/TwoFactorAuth/Factory/TwoFAServiceFactory.php
@@ -11,12 +11,12 @@
 
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Exception\AuthenticationTypeNotFoundException;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;
 
 class TwoFAServiceFactory implements TwoFAServiceFactoryInterface
 {
     public function __construct(
-        private TwoFASettingsInterface $settings,
+        private TwoFAShopSettingsInterface $settings,
         private array $implementations,
     ) {
     }
diff --git a/src/Authentication/TwoFactorAuth/Service/TwoFAUserService.php b/src/Authentication/TwoFactorAuth/Service/TwoFAUserService.php
@@ -12,9 +12,9 @@
 use OxidEsales\Eshop\Core\Utils;
 use OxidEsales\EshopCommunity\Internal\Framework\Session\SessionInterface;
 use OxidEsales\SecurityModule\Authentication\Service\InternalRedirectServiceInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Repository\UserRepositoryInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Service\UserLoginAdapterInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettingsInterface;
 
 /**
  * todo-high: challenge the idea - session part should go to the separate login state service
@@ -25,12 +25,12 @@ class TwoFAUserService implements TwoFAUserServiceInterface
 
     public function __construct(
         private TwoFAServiceInterface $twoFAService,
-        private TwoFASettingsInterface $settings,
+        private TwoFAShopSettingsInterface $settings,
         private Utils $utils,
         private SessionInterface $session,
         private UserLoginAdapterInterface $loginAdapter,
         private InternalRedirectServiceInterface $redirectService,
-        private UserRepositoryInterface $userRepository,
+        private TwoFAUserSettingsInterface $userSettings,
     ) {
     }
 
@@ -67,7 +67,6 @@ public function isTwoFARequired(string $userId): bool
             return false;
         }
 
-        $user = $this->userRepository->getUserById($userId);
-        return $user->isTwoFAEnabled();
+        return $this->userSettings->isEnabledForUser($userId);
     }
 }
diff --git a/src/Authentication/TwoFactorAuth/Service/services.yaml b/src/Authentication/TwoFactorAuth/Service/services.yaml
@@ -9,6 +9,3 @@ services:
     class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserService
     public: true
 
-  OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserSettingsServiceInterface:
-    class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserSettingsService
-    public: true
diff --git a/src/Authentication/TwoFactorAuth/Settings/TwoFAShopSettings.php b/src/Authentication/TwoFactorAuth/Settings/TwoFAShopSettings.php
@@ -13,7 +13,7 @@
 use OxidEsales\EshopCommunity\Internal\Framework\Module\Facade\ModuleSettingServiceInterface;
 use OxidEsales\SecurityModule\Core\Module;
 
-class TwoFASettings implements TwoFASettingsInterface
+class TwoFAShopSettings implements TwoFAShopSettingsInterface
 {
     public const ACTIVE = 'oeSecurityTwoFactorAuthEnabled';
 
diff --git a/src/Authentication/TwoFactorAuth/Settings/TwoFAShopSettingsInterface.php b/src/Authentication/TwoFactorAuth/Settings/TwoFAShopSettingsInterface.php
@@ -9,7 +9,7 @@
 
 namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings;
 
-interface TwoFASettingsInterface
+interface TwoFAShopSettingsInterface
 {
     public function isTwoFactorAuthEnabled(): bool;
 
diff --git a/src/Authentication/TwoFactorAuth/Settings/TwoFAUserSettings.php b/src/Authentication/TwoFactorAuth/Settings/TwoFAUserSettings.php
@@ -7,11 +7,11 @@
 
 declare(strict_types=1);
 
-namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service;
+namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings;
 
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Repository\UserRepositoryInterface;
 
-class TwoFAUserSettingsService implements TwoFAUserSettingsServiceInterface
+class TwoFAUserSettings implements TwoFAUserSettingsInterface
 {
     public function __construct(
         private UserRepositoryInterface $userRepository,
diff --git a/src/Authentication/TwoFactorAuth/Settings/TwoFAUserSettingsInterface.php b/src/Authentication/TwoFactorAuth/Settings/TwoFAUserSettingsInterface.php
@@ -7,11 +7,11 @@
 
 declare(strict_types=1);
 
-namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service;
+namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings;
 
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Exception\UserNotFoundException;
 
-interface TwoFAUserSettingsServiceInterface
+interface TwoFAUserSettingsInterface
 {
     /** @throws UserNotFoundException */
     public function isEnabledForUser(string $userId): bool;
diff --git a/src/Authentication/TwoFactorAuth/Settings/services.yaml b/src/Authentication/TwoFactorAuth/Settings/services.yaml
@@ -3,6 +3,10 @@ services:
     autowire: true
     public: false
 
-  OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface:
-    class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettings
+  OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface:
+    class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettings
+    public: true
+
+  OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettingsInterface:
+    class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettings
     public: true
diff --git a/tests/Integration/ServiceAvailabilityTest.php b/tests/Integration/ServiceAvailabilityTest.php
@@ -45,7 +45,7 @@ public static function serviceAvailabilityDataProvider(): array
             [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface::class],
             [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserServiceInterface::class],
 
-            [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface::class],
+            [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface::class],
 
             [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Transput\AuthCodeRequestInterface::class],
             [\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Transput\JsonResponseInterface::class],
diff --git a/tests/Unit/Authentication/TwoFactorAuth/Factory/TwoFAServiceFactoryTest.php b/tests/Unit/Authentication/TwoFactorAuth/Factory/TwoFAServiceFactoryTest.php
@@ -13,7 +13,7 @@
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Factory\TwoFAServiceFactory;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Factory\TwoFAServiceFactoryInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;
 use PHPUnit\Framework\TestCase;
 
 class TwoFAServiceFactoryTest extends TestCase
@@ -23,7 +23,7 @@ public function testCreateReturnsServiceMatchingConfiguredType(): void
         $otpServiceStub = $this->createStub(TwoFAServiceInterface::class);
         $totpServiceStub = $this->createStub(TwoFAServiceInterface::class);
 
-        $settingsStub = $this->createStub(TwoFASettingsInterface::class);
+        $settingsStub = $this->createStub(TwoFAShopSettingsInterface::class);
         $settingsStub->method('getTwoFactorAuthType')->willReturn('otp');
 
         $sut = $this->getSut(
@@ -36,7 +36,7 @@ public function testCreateReturnsServiceMatchingConfiguredType(): void
 
     public function testCreateThrowsForUnknownType(): void
     {
-        $settingsStub = $this->createStub(TwoFASettingsInterface::class);
+        $settingsStub = $this->createStub(TwoFAShopSettingsInterface::class);
         $settingsStub->method('getTwoFactorAuthType')->willReturn('unknown');
 
         $sut = $this->getSut(
@@ -48,11 +48,11 @@ public function testCreateThrowsForUnknownType(): void
     }
 
     private function getSut(
-        TwoFASettingsInterface $settings = null,
+        TwoFAShopSettingsInterface $settings = null,
         array $implementations = [],
     ): TwoFAServiceFactoryInterface {
         return new TwoFAServiceFactory(
-            settings: $settings ?? $this->createStub(TwoFASettingsInterface::class),
+            settings: $settings ?? $this->createStub(TwoFAShopSettingsInterface::class),
             implementations: $implementations,
         );
     }
diff --git a/tests/Unit/Authentication/TwoFactorAuth/Service/TwoFAUserServiceTest.php b/tests/Unit/Authentication/TwoFactorAuth/Service/TwoFAUserServiceTest.php
@@ -12,12 +12,11 @@
 use OxidEsales\Eshop\Core\Utils;
 use OxidEsales\EshopCommunity\Internal\Framework\Session\SessionInterface;
 use OxidEsales\SecurityModule\Authentication\Service\InternalRedirectServiceInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\DTO\UserInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Repository\UserRepositoryInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Infrastructure\Service\UserLoginAdapterInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettingsInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface;
 use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserService;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;
 use Generator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
@@ -40,7 +39,7 @@ public function startChallengeForUserStoresPendingUserTriggersChallengeAndRedire
             ->method('triggerChallenge')
             ->with($userId);
 
-        $settingsStub = $this->createStub(TwoFASettingsInterface::class);
+        $settingsStub = $this->createStub(TwoFAShopSettingsInterface::class);
         $settingsStub->method('getVerificationUrl')->willReturn($verificationUrl = uniqid());
 
         $utilsSpy = $this->createMock(Utils::class);
@@ -86,18 +85,15 @@ public function isChallengeVerifiedProxiesToTwoFAService(): void
 
     #[Test]
     #[DataProvider('isTwoFARequiredDataProvider')]
-    public function isTwoFARequired(bool $shopSettingEnabled, bool $userTwoFAEnabled, bool $expected): void
+    public function isTwoFARequired(bool $shopSettingEnabled, bool $userSettingEnabled, bool $expected): void
     {
-        $settingsStub = $this->createStub(TwoFASettingsInterface::class);
-        $settingsStub->method('isTwoFactorAuthEnabled')->willReturn($shopSettingEnabled);
+        $shopSettingsStub = $this->createStub(TwoFAShopSettingsInterface::class);
+        $shopSettingsStub->method('isTwoFactorAuthEnabled')->willReturn($shopSettingEnabled);
 
-        $userStub = $this->createStub(UserInterface::class);
-        $userStub->method('isTwoFAEnabled')->willReturn($userTwoFAEnabled);
+        $userSettingsStub = $this->createStub(TwoFAUserSettingsInterface::class);
+        $userSettingsStub->method('isEnabledForUser')->willReturn($userSettingEnabled);
 
-        $repositoryStub = $this->createStub(UserRepositoryInterface::class);
-        $repositoryStub->method('getUserById')->willReturn($userStub);
-
-        $sut = $this->getSut(settings: $settingsStub, userRepository: $repositoryStub);
+        $sut = $this->getSut(settings: $shopSettingsStub, userSettings: $userSettingsStub);
 
         $this->assertSame($expected, $sut->isTwoFARequired(uniqid()));
     }
@@ -106,22 +102,22 @@ public static function isTwoFARequiredDataProvider(): Generator
     {
         yield 'shop setting disabled, user has it disabled' => [
             'shopSettingEnabled' => false,
-            'userTwoFAEnabled' => false,
+            'userSettingEnabled' => false,
             'expected' => false,
         ];
         yield 'shop setting disabled, user has it enabled' => [
             'shopSettingEnabled' => false,
-            'userTwoFAEnabled' => true,
+            'userSettingEnabled' => true,
             'expected' => false,
         ];
         yield 'shop setting enabled, user has it disabled' => [
             'shopSettingEnabled' => true,
-            'userTwoFAEnabled' => false,
+            'userSettingEnabled' => false,
             'expected' => false,
         ];
         yield 'shop setting enabled, user has it enabled' => [
             'shopSettingEnabled' => true,
-            'userTwoFAEnabled' => true,
+            'userSettingEnabled' => true,
             'expected' => true,
         ];
     }
@@ -165,21 +161,21 @@ public function loginUserLoadsUserLoginsClearsSessionAndRedirects(): void
 
     private function getSut(
         TwoFAServiceInterface $twoFAService = null,
-        TwoFASettingsInterface $settings = null,
+        TwoFAShopSettingsInterface $settings = null,
         Utils $utils = null,
         SessionInterface $session = null,
         UserLoginAdapterInterface $loginAdapter = null,
         InternalRedirectServiceInterface $redirectService = null,
-        UserRepositoryInterface $userRepository = null,
+        TwoFAUserSettingsInterface $userSettings = null,
     ): TwoFAUserService {
         return new TwoFAUserService(
             twoFAService: $twoFAService ?? $this->createStub(TwoFAServiceInterface::class),
-            settings: $settings ?? $this->createStub(TwoFASettingsInterface::class),
+            settings: $settings ?? $this->createStub(TwoFAShopSettingsInterface::class),
             utils: $utils ?? $this->createStub(Utils::class),
             session: $session ?? $this->createStub(SessionInterface::class),
             loginAdapter: $loginAdapter ?? $this->createStub(UserLoginAdapterInterface::class),
             redirectService: $redirectService ?? $this->createStub(InternalRedirectServiceInterface::class),
-            userRepository: $userRepository ?? $this->createStub(UserRepositoryInterface::class),
+            userSettings: $userSettings ?? $this->createStub(TwoFAUserSettingsInterface::class),
         );
     }
 }
diff --git a/tests/Unit/Authentication/TwoFactorAuth/Settings/TwoFAShopSettingsTest.php b/tests/Unit/Authentication/TwoFactorAuth/Settings/TwoFAShopSettingsTest.php
@@ -11,21 +11,21 @@
 
 use OxidEsales\Eshop\Core\Config;
 use OxidEsales\EshopCommunity\Internal\Framework\Module\Facade\ModuleSettingServiceInterface;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettings;
-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettings;
+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;
 use OxidEsales\SecurityModule\Core\Module;
 use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\String\UnicodeString;
 
-class TwoFASettingsTest extends TestCase
+class TwoFAShopSettingsTest extends TestCase
 {
     #[Test]
     public function isTwoFactorAuthEnabledReturnsTrueWhenEnabled(): void
     {
         $moduleSettingServiceStub = $this->createStub(ModuleSettingServiceInterface::class);
         $moduleSettingServiceStub->method('getBoolean')
-            ->with(TwoFASettings::ACTIVE, Module::MODULE_ID)
+            ->with(TwoFAShopSettings::ACTIVE, Module::MODULE_ID)
             ->willReturn(true);
 
         $sut = $this->getSut(moduleSettingService: $moduleSettingServiceStub);
@@ -38,7 +38,7 @@ public function isTwoFactorAuthEnabledReturnsFalseWhenDisabled(): void
     {
         $moduleSettingServiceStub = $this->createStub(ModuleSettingServiceInterface::class);
         $moduleSettingServiceStub->method('getBoolean')
-            ->with(TwoFASettings::ACTIVE, Module::MODULE_ID)
+            ->with(TwoFAShopSettings::ACTIVE, Module::MODULE_ID)
             ->willReturn(false);
 
         $sut = $this->getSut(moduleSettingService: $moduleSettingServiceStub);
@@ -52,7 +52,7 @@ public function getTwoFactorAuthTypeReturnsConfiguredType(): void
         $type = uniqid();
         $moduleSettingServiceStub = $this->createStub(ModuleSettingServiceInterface::class);
         $moduleSettingServiceStub->method('getString')
-            ->with(TwoFASettings::TWO_FACTOR_TYPE, Module::MODULE_ID)
+            ->with(TwoFAShopSettings::TWO_FACTOR_TYPE, Module::MODULE_ID)
             ->willReturn(new UnicodeString($type));
 
         $sut = $this->getSut(moduleSettingService: $moduleSettingServiceStub);
@@ -74,14 +74,14 @@ public function getVerificationUrlReturnsVerificationControllerUrl(): void
     #[Test]
     public function implementsInterface(): void
     {
-        $this->assertInstanceOf(TwoFASettingsInterface::class, $this->getSut());
+        $this->assertInstanceOf(TwoFAShopSettingsInterface::class, $this->getSut());
     }
 
     private function getSut(
         Config $config = null,
         ModuleSettingServiceInterface $moduleSettingService = null,
-    ): TwoFASettings {
-        return new TwoFASettings(
+    ): TwoFAShopSettings {
+        return new TwoFAShopSettings(
             config: $config ?? $this->createStub(Config::class),
             moduleSettingService: $moduleSettingService ?? $this->createStub(ModuleSettingServiceInterface::class),
         );

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`use OxidEsales\Eshop\Application\Controller\FrontendController;`
`13`	`13`	`use OxidEsales\Eshop\Core\Registry;`
`14`		`-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAUserSettingsServiceInterface;`
	`14`	`+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAUserSettingsInterface;`
`15`	`15`
`16`	`16`	`class AccountSecurityController extends FrontendController`
`17`	`17`	`{`
`@@ -22,7 +22,7 @@ class AccountSecurityController extends FrontendController`
`22`	`22`	`protected $_sThisTemplate = '@oe_security_module/templates/account_security';`
`23`	`23`
`24`	`24`	`public function __construct(`
`25`		`- private readonly TwoFAUserSettingsServiceInterface $userSettingsService,`
	`25`	`+ private readonly TwoFAUserSettingsInterface $userSettingsService,`
`26`	`26`	`) {`
`27`	`27`	`parent::__construct();`
`28`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,12 @@`
`11`	`11`
`12`	`12`	`use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Exception\AuthenticationTypeNotFoundException;`
`13`	`13`	`use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface;`
`14`		`-use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFASettingsInterface;`
	`14`	`+use OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings\TwoFAShopSettingsInterface;`
`15`	`15`
`16`	`16`	`class TwoFAServiceFactory implements TwoFAServiceFactoryInterface`
`17`	`17`	`{`
`18`	`18`	`public function __construct(`
`19`		`- private TwoFASettingsInterface $settings,`
	`19`	`+ private TwoFAShopSettingsInterface $settings,`
`20`	`20`	`private array $implementations,`
`21`	`21`	`) {`
`22`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`use OxidEsales\EshopCommunity\Internal\Framework\Module\Facade\ModuleSettingServiceInterface;`
`14`	`14`	`use OxidEsales\SecurityModule\Core\Module;`
`15`	`15`
`16`		`-class TwoFASettings implements TwoFASettingsInterface`
	`16`	`+class TwoFAShopSettings implements TwoFAShopSettingsInterface`
`17`	`17`	`{`
`18`	`18`	`public const ACTIVE = 'oeSecurityTwoFactorAuthEnabled';`
`19`	`19`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`
`10`	`10`	`namespace OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Settings;`
`11`	`11`
`12`		`-interface TwoFASettingsInterface`
	`12`	`+interface TwoFAShopSettingsInterface`
`13`	`13`	`{`
`14`	`14`	`public function isTwoFactorAuthEnabled(): bool;`
`15`	`15`