Skip to content

Commit fe3c286

Browse files
committed
OXDEV-9078 Register all new services
1 parent 3f5f901 commit fe3c286

6 files changed

Lines changed: 33 additions & 5 deletions

File tree

src/Authentication/TwoFactorAuth/Factory/services.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ services:
77
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Factory\TwoFAServiceFactory
88
arguments:
99
$implementations:
10-
otp: '@OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\OTPService'
10+
otp: '@OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\OtpFacade'
1111

1212
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface:
1313
factory: ['@OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Factory\TwoFAServiceFactoryInterface', 'create']
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
services:
2+
_defaults:
3+
autowire: true
4+
public: false
5+
6+
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Infrastructure\Repository\OtpChallengeStateRepositoryInterface:
7+
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Infrastructure\Repository\OtpChallengeStateRepository
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
services:
2+
_defaults:
3+
autowire: true
4+
public: false
5+
6+
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpChallengeStateServiceInterface:
7+
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpChallengeStateService
8+
9+
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeValidatorServiceInterface:
10+
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeValidatorService
11+
12+
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeGeneratorServiceInterface:
13+
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeGeneratorService
14+
15+
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeHasherServiceInterface:
16+
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeHasherService
Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
imports:
2+
- { resource: Infrastructure/Repository/services.yaml }
3+
- { resource: Service/services.yaml }
24
- { resource: Notifier/services.yaml }
35

46
services:
@@ -7,6 +9,3 @@ services:
79
public: false
810

911
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\OtpFacade: ~
10-
11-
OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Infrastructure\Repository\OtpChallengeStateRepositoryInterface:
12-
class: OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Infrastructure\Repository\OtpChallengeStateRepository

tests/Integration/ServiceAvailabilityTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,18 @@ public function testServicesAvailable(string $serviceId): void
3838

3939
public static function serviceAvailabilityDataProvider(): array
4040
{
41+
// phpcs:disable
4142
return [
4243
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Factory\TwoFAServiceFactoryInterface::class],
44+
4345
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\Service\TwoFAServiceInterface::class],
46+
4447
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Infrastructure\Repository\OtpChallengeStateRepositoryInterface::class],
48+
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeGeneratorServiceInterface::class],
49+
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Service\OtpCodeHasherServiceInterface::class],
4550
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Notifier\OtpNotifierInterface::class],
4651
[\OxidEsales\SecurityModule\Authentication\TwoFactorAuth\OTP\Notifier\Factory\OtpNotifierFactoryInterface::class],
4752
];
53+
// phpcs:enable
4854
}
4955
}

tests/Unit/Authentication/TwoFactorAuth/OTP/OtpFacadeTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
use PHPUnit\Framework\Attributes\Test;
1919
use PHPUnit\Framework\TestCase;
2020

21-
class OTPServiceTest extends TestCase
21+
class OtpFacadeTest extends TestCase
2222
{
2323
#[Test]
2424
public function isVerifiedReturnsFalseWhenNoChallengeState(): void

0 commit comments

Comments
 (0)