Merge pull request 'Refactor Hiera namespaces to standardize system lookups' (#1529) from fix_overrider into master

Reviewed-on: https://gitea.obmondo.com/EnableIT/LinuxAid/pulls/1529

Author: ashish1099

modules/enableit/common/REFERENCE.md

@@ -1,5 +1,4 @@
 ---
-common::openvox::linuxaid_cli::checksums:
 common::monitor::prometheus::install_method: "url"
 common::monitor::prometheus::env_file_path: "/etc/default"
 common::monitor::prometheus::server::checksums:

modules/enableit/common/data/architectures/armv7l.yaml

@@ -20,7 +20,7 @@ lookup_options:
     merge: "unique"
   common::system::ssh_authorized_keys:
     merge: "deep"
-  common::services::disabled_services:
+  common::system::disabled_services:
     merge: "unique"
   common::system::package::manage:
     merge: "deep"
@@ -184,7 +184,6 @@ common::system::classes:
 ## System Settings
 common::system::repo::manage: true
 common::system::cron::purge_unmanaged: false
-common::system::services::manage: true
 common::user_management::security::manage: true
 common::system::mail::manage: false
 
@@ -305,7 +304,7 @@ common::system::package::default_packages:
   - "tmux"
   - "net-tools"
 
-common::system::services::disabled_services:
+common::system::disabled_services:
   - "smartd"
   - "rpc-svcgssd"
   - "sssd-pac"
@@ -327,7 +326,7 @@ common::system::openvox::configure_agent: true
 # Update other architecture checksums in their respective heira config file.
 # https://github.com/Obmondo/LinuxAid/blob/master/modules/enableit/common/data/architectures/armv7l.yaml
 common::system::openvox::linuxaid_cli::install_method: package
-common::system::openvox::linuxaid_cli::version: 1.2.0
+common::system::openvox::linuxaid_cli::version: 1.2.1
 common::system::openvox::linuxaid_cli::checksums:
   1.2.0: 53d285fb6a8fca93609fe0ce71fc31ea0158aafefb3e7890b82b09a6d18134e4
   1.2.1: 4b3f7e4acc244a17e8c1294ce2029107b542cec9b6627f39387397a6406bd0af

modules/enableit/common/data/common.yaml

@@ -1,10 +1,7 @@
 ---
-common::mail::maildrop_perms: 'o=rwx,g=wx'
-
+common::system::mail::maildrop_perms: 'o=rwx,g=wx'
 common::logging::log_dir_group: 'root'
-
 common::user_management::security::selinux::enable: true
-
 common::user_management::sshd::subsystems:
   sftp:
     '/usr/libexec/openssh/sftp-server -f AUTHPRIV -l INFO'

modules/enableit/common/data/os/RedHat.yaml

@@ -18,6 +18,8 @@
 #
 # @param enable Enable or disable the forwarder. Defaults to false.
 #
+# @param manage Whether to include the underlying profile to manage the forwarder.
+#
 # @param noop_value No-operation mode value. Defaults to undef.
 #
 # @groups settings enable, noop_value
@@ -44,6 +46,7 @@
   Eit_types::Noop_Value $noop_value          = undef,
 ) {
 
+
   if $manage {
     contain profile::collector::splunk::forwarder
   }

modules/enableit/common/manifests/monitor/splunk/forwarder.pp

@@ -149,7 +149,7 @@
 
       '/var/spool/postfix/maildrop':
         group => 'postdrop',
-        mode  => lookup('common::mail::maildrop_perms'),
+        mode  => lookup('common::system::mail::maildrop_perms'),
     }
     $aliases.map |$target, $recipient| {
       mailalias { $target: