Skip to content

Commit 9ba8547

Browse files
committed
Error messages: improve unicode formatting
1 parent 3fea472 commit 9ba8547

3 files changed

Lines changed: 13 additions & 11 deletions

File tree

lib/fault.ml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -178,12 +178,14 @@ module Policy = struct
178178

179179
let rec pp_map ppf = function
180180
| name, Level {expl; lvl} ->
181-
Pp.fp ppf "@;−%a%a:@;@[<hov>%a@]"
181+
Pp.fp ppf "@;@<1>%s%a%a:@;@[<hov>%a@]"
182+
""
182183
Format_tags.(tagged Title) name
183184
pp_lvl lvl
184185
Format.pp_print_text expl
185186
| name, Map { lvl; expl; map } ->
186-
Pp.fp ppf "@;−%a%a:%s@; @[<v2> %a @]"
187+
Pp.fp ppf "@;@<1>%s%a%a:%s@; @[<v2> %a @]"
188+
""
187189
Format_tags.(tagged Title) name
188190
pp_lvl lvl
189191
expl

lib/loc.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ type 'a ext = { loc:t; data:'a }
99

1010
let pp ppf = function
1111
| Nowhere -> ()
12-
| Simple {line;start;stop} -> Pp.fp ppf "l%d.%d−%d" line start stop
12+
| Simple {line;start;stop} -> Pp.fp ppf "l%d.%d@<1>%s%d" line start "" stop
1313
| Multiline {start=(l1,c1); stop = (l2,c2) } ->
14-
Pp.fp ppf "l%d.%d−l%d.%d" l1 c1 l2 c2
14+
Pp.fp ppf "l%d.%d@<1>%sl%d.%d" l1 c1 "" l2 c2
1515

1616
let create loc data = {loc; data}
1717
let nowhere data = { loc = Nowhere; data}

lib/solver.ml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ module Failure = struct
141141
| Some { Loc.data = y,path ; loc } ->
142142
let next = resolver y path in
143143
begin
144-
Pp.fp ppf " (%a)⟶@ " Uloc.Pp.tagged {pkg=u.input.src; loc};
144+
Pp.fp ppf " @<1>%s(%a)@<1>%s@ " "" Uloc.Pp.tagged {pkg=u.input.src; loc} "";
145145
pp_circular block resolver map start false ppf next
146146
end
147147

@@ -151,25 +151,25 @@ module Failure = struct
151151
let path_pp = Pkg.pp in
152152
match st with
153153
| Internal_error ->
154-
Pp.fp ppf "@[<hov 2> −Codept internal error for compilation units: {%a}@] "
154+
Pp.fp ppf "@[<hov 2> @<1>%sCodept internal error for compilation units: {%a}@] " ""
155155
Pp.(list ~sep:(s ", @ ") @@ path_pp ) (paths units)
156156

157157
| Extern path ->
158-
Pp.fp ppf "@[<hov 2> −Non-resolved external dependency.@;\
158+
Pp.fp ppf "@[<hov 2> @<1>%sNon-resolved external dependency.@;\
159159
The following compilation units {%a} @ depend on \
160-
the unknown module \"%a\" @]"
160+
the unknown module \"%a\" @]" ""
161161
Pp.(list ~sep:(s ", ") @@ path_pp ) (paths units)
162162
Namespaced.pp path
163163
| Depend_on path ->
164164
let u = fst @@ Mp.find path map in (* map ∋ name *)
165165
Pp.fp ppf
166-
"@[<hov 2> −Non-resolved internal dependency.@;\
166+
"@[<hov 2> @<1>%sNon-resolved internal dependency.@;\
167167
The following compilation units {%a}@ depend on the \
168-
compilation units \"%a\" that could not be resolved.@]"
168+
compilation units \"%a\" that could not be resolved.@]" ""
169169
Pp.(list ~sep:(s ",@ ") @@ Pkg.pp ) (paths units)
170170
path_pp u.input.src
171171
| Cycle name ->
172-
Pp.fp ppf "@[<hov 4> −Circular dependencies: @ @[%a@]@]"
172+
Pp.fp ppf "@[<hov 4> @<1>%sCircular dependencies: @ @[%a@]@]" ""
173173
(pp_circular block resolver map name.data true) name.data
174174

175175
let pp block resolver map ppf m =

0 commit comments

Comments
 (0)