Skip to content

Commit af34422

Browse files
authored
Merge pull request #566 from OctopusDeploy/sjc/ee-deprov-json-only
Fix output only json if using json output for ephemeral environment deprovisioning commands
2 parents 5d0e58b + 47bb781 commit af34422

3 files changed

Lines changed: 20 additions & 7 deletions

File tree

pkg/cmd/ephemeralenvironment/deprovision-environment/deprovision_environment.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,14 @@ func DeprovisionEnvironmentRun(deprovisionEnvironmentOptions *DeprovisionEnviron
105105
return err
106106
}
107107

108-
command.Printf("Deprovisioning ephemeral environment '%s' with id '%s'...\n", deprovisionEnvironmentOptions.Name.Value, environment.ID)
108+
message := fmt.Sprintf("Deprovisioning ephemeral environment '%s' with id '%s'...\n", deprovisionEnvironmentOptions.Name.Value, environment.ID)
109109

110-
util.OutputDeprovisionResult(command, response.DeprovisioningRuns)
110+
util.OutputDeprovisionResult(message, command, response.DeprovisioningRuns)
111+
112+
if !deprovisionEnvironmentOptions.NoPrompt {
113+
autoCmd := flag.GenerateAutomationCmd(deprovisionEnvironmentOptions.CmdPath, deprovisionEnvironmentOptions.Name)
114+
fmt.Fprintf(command.OutOrStdout(), "\nAutomation Command: %s\n", autoCmd)
115+
}
111116

112117
return nil
113118
}

pkg/cmd/ephemeralenvironment/deprovision-project/deprovision_project.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,23 +152,27 @@ func DeprovisionEphemeralEnvironmentProject(cmd *cobra.Command, opts *Deprovisio
152152

153153
environmentId := environmentResource.ID
154154

155-
cmd.Printf("Deprovisioning ephemeral environment '%s' with id '%s' for project '%s'...\n", opts.Name.Value, environmentId, opts.Project.Value)
156-
157155
projectId := projectResource.GetID()
158156

159157
deprovisionedEnv, err := ephemeralenvironments.DeprovisionForProject(opts.Client, opts.Space.ID, environmentId, projectId)
160158
if err != nil {
161159
return err
162160
}
163161

164-
cmd.Printf("\nSuccessfully deprovisioned ephemeral environment for project '%s' with id '%s'.\n", opts.Project.Value, environmentId)
165162
runs := []ephemeralenvironments.DeprovisioningRunbookRun{}
166163

167164
if deprovisionedEnv.DeprovisioningRun.RunbookRunID != "" {
168165
runs = append(runs, deprovisionedEnv.DeprovisioningRun)
169166
}
170167

171-
util.OutputDeprovisionResult(cmd, runs)
168+
message := fmt.Sprintf("Deprovisioning ephemeral environment '%s' with id '%s' for project '%s'...\n", opts.Name.Value, environmentId, opts.Project.Value)
169+
170+
util.OutputDeprovisionResult(message, cmd, runs)
171+
172+
if !opts.NoPrompt {
173+
autoCmd := flag.GenerateAutomationCmd(opts.CmdPath, opts.Name, opts.Project)
174+
fmt.Fprintf(cmd.OutOrStdout(), "\nAutomation Command: %s\n", autoCmd)
175+
}
172176

173177
return nil
174178
}

pkg/cmd/ephemeralenvironment/util/util.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ func GetByName(client *client.Client, name string, spaceID string) (*ephemeralen
4040
}
4141
}
4242

43-
func OutputDeprovisionResult(command *cobra.Command, deprovisioningRuns []ephemeralenvironments.DeprovisioningRunbookRun) {
43+
func OutputDeprovisionResult(message string, command *cobra.Command, deprovisioningRuns []ephemeralenvironments.DeprovisioningRunbookRun) {
4444
outputFormat, err := command.Flags().GetString(constants.FlagOutputFormat)
4545
if err != nil {
4646
outputFormat = constants.OutputFormatTable
@@ -52,6 +52,8 @@ func OutputDeprovisionResult(command *cobra.Command, deprovisioningRuns []epheme
5252

5353
switch outputFormat {
5454
case constants.OutputFormatBasic:
55+
command.Print(message)
56+
5557
if len(deprovisioningRuns) == 0 {
5658
command.Println("Environment deprovisioned without running a runbook.")
5759
} else {
@@ -68,6 +70,8 @@ func OutputDeprovisionResult(command *cobra.Command, deprovisioningRuns []epheme
6870
command.Println()
6971
}
7072
default:
73+
command.Print(message)
74+
7175
if len(deprovisioningRuns) == 0 {
7276
command.Println("Environment deprovisioned without running a runbook.")
7377
} else {

0 commit comments

Comments
 (0)