Skip to content

Commit e7dacb1

Browse files
committed
update TODO comment and add changelog file
Signed-off-by: Igor Braga <5835477+bragaigor@users.noreply.github.com>
1 parent 7def7ce commit e7dacb1

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

changelog/bragaigor-nit-4241.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
### Changed
2+
- enable execution only mode

cmd/nitro/nitro.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,13 +318,12 @@ func mainImpl() int {
318318

319319
log.Info("connected to l1 chain", "l1url", nodeConfig.ParentChain.Connection.URL, "l1chainid", nodeConfig.ParentChain.ID)
320320

321-
// TODO: do we need rollupAddrs for execution node? We seem to need it for initialzing chainConfig
322-
// if consensusNodeEnabled {
321+
// TODO: should rollupAddrs be created for consensus or execution node? It's used in both
323322
rollupAddrs, err = chaininfo.GetRollupAddressesConfig(nodeConfig.Chain.ID, nodeConfig.Chain.Name, nodeConfig.Chain.InfoFiles, nodeConfig.Chain.InfoJson)
324323
if err != nil {
325324
log.Crit("error getting rollup addresses", "err", err)
326325
}
327-
// }
326+
328327
arbSys, _ := precompilesgen.NewArbSys(types.ArbSysAddress, l1Client)
329328
l1Reader, err = headerreader.New(ctx, l1Client, func() *headerreader.Config { return &liveNodeConfig.Get().Node.ParentChainReader }, arbSys)
330329
if err != nil {

0 commit comments

Comments
 (0)