Skip to content

Commit f9c29ad

Browse files
Merge pull request #80 from Omega-R/feature/hotfix
pick and crop examples was updated
2 parents 0c1ad79 + 9630d2d commit f9c29ad

3 files changed

Lines changed: 25 additions & 33 deletions

File tree

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
buildscript {
44
ext.kotlin_version = '1.2.30'
5-
ext.supportVersion = '27.0.2'
5+
ext.supportVersion = '27.1.1'
66
ext.compileSdkVersion = 27
77
ext.targetSdkVersion = 27
88
ext.javapoet = '1.9.0'
@@ -12,7 +12,7 @@ buildscript {
1212
jcenter()
1313
}
1414
dependencies {
15-
classpath 'com.android.tools.build:gradle:3.1.0'
15+
classpath 'com.android.tools.build:gradle:3.1.1'
1616
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
1717
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.0'
1818

examples/src/main/java/com/omega_r/omegaintentbuilder/CropImageActivity.java

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@
99
import android.widget.Toast;
1010
import com.omega_r.libs.omegaintentbuilder.OmegaIntentBuilder;
1111
import com.omega_r.libs.omegaintentbuilder.downloader.DownloadCallback;
12-
import com.omega_r.libs.omegaintentbuilder.handlers.ActivityResultCallback;
1312
import com.omega_r.libs.omegaintentbuilder.handlers.ContextIntentHandler;
1413
import com.omega_r.libs.omegaintentbuilder.types.MimeTypes;
1514

1615
import org.jetbrains.annotations.NotNull;
1716

1817
public class CropImageActivity extends BaseActivity implements View.OnClickListener {
1918

19+
private static final int REQUEST_CODE = 111;
2020
private static final int DEFAULT_OUTPUT_X = 200;
2121
private static final int DEFAULT_OUTPUT_Y = 200;
2222

@@ -49,14 +49,9 @@ private void crop() {
4949
.cropImage()
5050
.property(DEFAULT_OUTPUT_X, DEFAULT_OUTPUT_Y)
5151
.bitmap(BitmapFactory.decodeResource(getResources(), R.drawable.crop_image))
52-
.createIntentHandler()
52+
.createIntentHandler(this)
5353
.failToast("You don't have app for cropping image")
54-
.startActivityForResult(new ActivityResultCallback() {
55-
@Override
56-
public void onActivityResult(int resultCode, @NotNull Intent data) {
57-
onResult(resultCode, data);
58-
}
59-
});
54+
.startActivityForResult(REQUEST_CODE);
6055
}
6156

6257
private void cropFromInternet() {
@@ -69,18 +64,14 @@ private void cropFromInternet() {
6964
@Override
7065
public void onDownloaded(boolean success, @NotNull ContextIntentHandler contextIntentHandler) {
7166
hideProgress();
72-
contextIntentHandler.startActivityForResult(new ActivityResultCallback() {
73-
@Override
74-
public void onActivityResult(int resultCode, @NotNull Intent data) {
75-
onResult(resultCode, data);
76-
}
77-
});
67+
startActivityForResult(contextIntentHandler.getIntent(), REQUEST_CODE);
7868
}
7969
});
8070
}
8171

82-
private void onResult(int resultCode, Intent data) {
83-
if (resultCode == RESULT_OK) {
72+
@Override
73+
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
74+
if (requestCode == REQUEST_CODE && resultCode == RESULT_OK) {
8475
Bundle extras = data.getExtras();
8576
if (extras != null) {
8677
Bitmap cropped = extras.getParcelable("data");

examples/src/main/java/com/omega_r/omegaintentbuilder/PickImageActivity.java

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
public class PickImageActivity extends BaseActivity implements View.OnClickListener {
1919

20+
private static final int REQUEST_CODE = 141;
2021
private ImageView imageView;
2122

2223
@Override
@@ -34,20 +35,20 @@ public void onClick(View v) {
3435
.image()
3536
.multiply(false)
3637
.createIntentHandler(this)
37-
.startActivityForResult(new ActivityResultCallback() {
38-
@Override
39-
public void onActivityResult(int resultCode, @Nullable Intent data) {
40-
if (resultCode == RESULT_OK && data != null) {
41-
try {
42-
Bitmap bitmap = MediaStore.Images.Media.getBitmap(getContentResolver(), data.getData());
43-
imageView.setImageBitmap(bitmap);
44-
} catch (IOException exc) {
45-
exc.printStackTrace();
46-
}
47-
} else if (resultCode == RESULT_CANCELED) {
48-
Toast.makeText(getApplicationContext(), "Pick cancelled", Toast.LENGTH_SHORT).show();
49-
}
50-
}
51-
});
38+
.startActivityForResult(REQUEST_CODE);
39+
}
40+
41+
@Override
42+
protected void onActivityResult(int requestCode, int resultCode, Intent data) {
43+
if (requestCode == REQUEST_CODE && resultCode == RESULT_OK && data != null) {
44+
try {
45+
Bitmap bitmap = MediaStore.Images.Media.getBitmap(getContentResolver(), data.getData());
46+
imageView.setImageBitmap(bitmap);
47+
} catch (IOException exc) {
48+
exc.printStackTrace();
49+
}
50+
} else if (resultCode == RESULT_CANCELED) {
51+
Toast.makeText(getApplicationContext(), "Pick cancelled", Toast.LENGTH_SHORT).show();
52+
}
5253
}
5354
}

0 commit comments

Comments
 (0)