refactor(demo): [SDK-4217] remove stop-updating button and deprecate exit API (#1935)

Author: fadi-george

examples/demo/bun.lock

@@ -6,7 +6,7 @@ import { AppColors, AppSpacing } from '../theme';
 interface Props {
   label: string;
   onPress: () => void;
-  variant?: 'primary' | 'destructive' | 'outlined';
+  variant?: 'primary' | 'outlined';
   disabled?: boolean;
   loading?: boolean;
   testID?: string;
@@ -29,12 +29,9 @@ export default function ActionButton({
   const bgColor = variant === 'primary' ? AppColors.osPrimary : 'transparent';
 
   const borderStyle =
-    variant === 'outlined' || variant === 'destructive'
-      ? { borderWidth: 1, borderColor: AppColors.osPrimary }
-      : {};
+    variant === 'outlined' ? { borderWidth: 1, borderColor: AppColors.osPrimary } : {};
 
-  const textColor =
-    variant === 'outlined' || variant === 'destructive' ? AppColors.osPrimary : AppColors.white;
+  const textColor = variant === 'outlined' ? AppColors.osPrimary : AppColors.white;
 
   return (
     <TouchableOpacity

examples/demo/src/components/ActionButton.tsx

@@ -15,17 +15,10 @@ interface Props {
   onStart: (activityId: string, attributes: object, content: object) => void;
   onUpdate: (activityId: string, eventUpdates: Record<string, unknown>) => Promise<void>;
   onEnd: (activityId: string) => Promise<void>;
-  onStopUpdating: (activityId: string) => void;
   onInfoTap?: () => void;
 }
 
-export default function LiveActivitySection({
-  onStart,
-  onUpdate,
-  onEnd,
-  onStopUpdating,
-  onInfoTap,
-}: Props) {
+export default function LiveActivitySection({ onStart, onUpdate, onEnd, onInfoTap }: Props) {
   const [activityId, setActivityId] = useState('order-1');
   const [orderNumber, setOrderNumber] = useState('ORD-1234');
   const [statusIndex, setStatusIndex] = useState(0);
@@ -97,20 +90,12 @@ export default function LiveActivitySection({
           testID="update_live_activity_button"
         />
 
-        <ActionButton
-          label="STOP UPDATING LIVE ACTIVITY"
-          onPress={() => onStopUpdating(activityId)}
-          disabled={!activityId.trim()}
-          variant="outlined"
-          testID="stop_updating_live_activity_button"
-        />
-
         {/* Requires API key */}
         <ActionButton
           label="END LIVE ACTIVITY"
           onPress={() => onEnd(activityId)}
           disabled={!activityId.trim()}
-          variant="destructive"
+          variant="outlined"
           testID="end_live_activity_button"
         />
       </View>

examples/demo/src/components/sections/LiveActivitySection.tsx

@@ -266,7 +266,6 @@ type AppContextValue = {
   startDefaultLiveActivity: (activityId: string, attributes: object, content: object) => void;
   updateLiveActivity: (activityId: string, eventUpdates: Record<string, unknown>) => Promise<void>;
   endLiveActivity: (activityId: string) => Promise<void>;
-  stopUpdatingLiveActivity: (activityId: string) => void;
 };
 
 const AppContext = createContext<AppContextValue | null>(null);
@@ -715,12 +714,6 @@ export function AppContextProvider({ children }: Props) {
     Toast.show({ type: success ? 'info' : 'error', text1: msg });
   }, []);
 
-  const stopUpdatingLiveActivity = useCallback((activityId: string) => {
-    repository.exitLiveActivity(activityId);
-    log.i(TAG, `Exited Live Activity: ${activityId}`);
-    Toast.show({ type: 'info', text1: `Exited Live Activity: ${activityId}` });
-  }, []);
-
   const contextValue = useMemo<AppContextValue>(
     () => ({
       state,
@@ -757,7 +750,6 @@ export function AppContextProvider({ children }: Props) {
       startDefaultLiveActivity: startDefaultLiveActivity,
       updateLiveActivity,
       endLiveActivity,
-      stopUpdatingLiveActivity,
     }),
     [
       state,
@@ -794,7 +786,6 @@ export function AppContextProvider({ children }: Props) {
       startDefaultLiveActivity,
       updateLiveActivity,
       endLiveActivity,
-      stopUpdatingLiveActivity,
     ],
   );
 

examples/demo/src/context/AppContext.tsx

@@ -193,10 +193,6 @@ class OneSignalRepository {
   ): Promise<boolean> {
     return this.apiService.updateLiveActivity(activityId, event, eventUpdates);
   }
-
-  exitLiveActivity(activityId: string): void {
-    OneSignal.LiveActivities.exit(activityId);
-  }
 }
 
 export default OneSignalRepository;

examples/demo/src/repositories/OneSignalRepository.ts

@@ -163,7 +163,6 @@ export default function HomeScreen() {
             onStart={app.startDefaultLiveActivity}
             onUpdate={app.updateLiveActivity}
             onEnd={app.endLiveActivity}
-            onStopUpdating={app.stopUpdatingLiveActivity}
             onInfoTap={() => showTooltipModal('liveActivities')}
           />
         )}

examples/demo/src/screens/HomeScreen.tsx

@@ -16,7 +16,10 @@ export interface Spec extends TurboModule {
 
   // Live Activities (iOS only, stubs on Android)
   enterLiveActivity(activityId: string, token: string, callback: (result: Object) => void): void;
+
+  /** @deprecated Currently unsupported, avoid using this method. */
   exitLiveActivity(activityId: string, callback: (result: Object) => void): void;
+
   setPushToStartToken(activityType: string, token: string): void;
   removePushToStartToken(activityType: string): void;
   setupDefaultLiveActivity(options: Object | null): void;

src/NativeOneSignal.ts

@@ -175,6 +175,7 @@ export namespace OneSignal {
      *
      * Only applies to iOS
      *
+     * @deprecated Currently unsupported, avoid using this method.
      * @param activityId: The activity identifier the live activity on this device will no longer receive updates for.
      **/
     export function exit(activityId: string, handler: (result: object) => void = () => {}) {