Skip to content

Commit e3add88

Browse files
committed
Correctly scale tau-p according to dt and nstpcouple.
1 parent f4e9cd4 commit e3add88

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

python/BioSimSpace/Sandpit/Exscientia/Protocol/_config.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -535,9 +535,8 @@ def generateGromacsConfig(
535535
protocol_dict["pcoupl"] = "Berendsen" # Berendsen barostat.
536536
# Do the MC move every 100 steps to be the same as AMBER.
537537
protocol_dict["nstpcouple"] = 100
538-
# 4ps time constant for pressure coupling.
539-
# As the tau-p has to be 10 times larger than nstpcouple * dt (4 fs)
540-
protocol_dict["tau-p"] = 4
538+
# 25 times larger than nstpcouple * dt.
539+
protocol_dict["tau-p"] = 2500 * timestep
541540
protocol_dict["ref-p"] = (
542541
f"{self.protocol.getPressure().bar().value():.5f}" # Pressure in bar.
543542
)

python/BioSimSpace/_Config/_gromacs.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,9 +188,8 @@ def createConfig(self, version=None, extra_options={}, extra_lines=[]):
188188
protocol_dict["pcoupl"] = "berendsen"
189189
# Do the MC move every 100 steps to be the same as AMBER.
190190
protocol_dict["nstpcouple"] = 100
191-
# 4ps time constant for pressure coupling. The tau-p has to be
192-
# 10 times larger than nstpcouple * dt (4 fs)
193-
protocol_dict["tau-p"] = 4
191+
# 25 times larger than nstpcouple * dt.
192+
protocol_dict["tau-p"] = 2500 * timestep
194193
# Pressure in bar.
195194
protocol_dict["ref-p"] = (
196195
f"{self._protocol.getPressure().bar().value():.5f}"

0 commit comments

Comments
 (0)