deprecated old cloning logic / fixed spline cloning

Author: MattFiler

CathodeLib/Scripts/CATHODE/CommandsPAK/Components/ParameterData.cs

@@ -106,8 +106,13 @@ public object Clone()
             switch (dataType)
             {
                 case DataType.RESOURCE:
-                    return Utilities.CloneObject(this);
-                //HOTFIX FOR VECTOR 3 CLONE ISSUE - TODO: FIND WHY THIS ISN'T WORKING WITH MEMBERWISE CLONE
+                    cResource r = (cResource)this.MemberwiseClone();
+                    r.value = ((cResource)this).value.Select(item => (ResourceReference)item.Clone()).ToList();
+                    return r;
+                case DataType.SPLINE:
+                    cSpline s = (cSpline)this.MemberwiseClone();
+                    s.splinePoints = ((cSpline)this).splinePoints.Select(item => (cTransform)item.Clone()).ToList();
+                    return s;
                 case DataType.VECTOR:
                     cVector3 v3 = (cVector3)this.MemberwiseClone();
                     Vector3 v3_v = (Vector3)((cVector3)this).value;
@@ -132,7 +137,6 @@ public object Clone()
                     tr.rotation = new Vector3(tr_r.X, tr_r.Y, tr_r.Z);
 #endif
                     return tr;
-                //END OF HOTFIX - SHOULD THIS ALSO APPLY TO OTHERS?? SPLINE?
                 default:
                     return this.MemberwiseClone();
             }

CathodeLib/Scripts/Utilities.cs

@@ -184,19 +184,6 @@ public static void Write<T>(BinaryWriter stream, List<T> aux)
             Write<T>(stream, aux.ToArray<T>());
         }
 
-        //Clones an object (slow!)
-        public static T CloneObject<T>(T obj)
-        {
-            //A somewhat hacky an inefficient way of deep cloning an object (TODO: optimise this as we use it a lot!)
-            MemoryStream ms = new MemoryStream();
-            new BinaryFormatter().Serialize(ms, obj);
-            ms.Position = 0;
-            T obj2 = (T)new BinaryFormatter().Deserialize(ms);
-            ms.Close();
-            return obj2;
-            //obj.MemberwiseClone();
-        }
-
         //Generate a hashed string for use in the animation system (FNV hash)
         public static uint AnimationHashedString(string str)
         {