Skip to content

Commit 58016c1

Browse files
committed
Clarify documentation, minor whitespace changes
Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
1 parent b0aee16 commit 58016c1

12 files changed

Lines changed: 306 additions & 173 deletions

File tree

Doxyfile-html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1015,13 +1015,13 @@ STRIP_CODE_COMMENTS = YES
10151015
# function all documented functions referencing it will be listed.
10161016
# The default value is: NO.
10171017

1018-
REFERENCED_BY_RELATION = YES
1018+
REFERENCED_BY_RELATION = NO
10191019

10201020
# If the REFERENCES_RELATION tag is set to YES then for each documented function
10211021
# all documented entities called/used by that function will be listed.
10221022
# The default value is: NO.
10231023

1024-
REFERENCES_RELATION = YES
1024+
REFERENCES_RELATION = NO
10251025

10261026
# If the REFERENCES_LINK_SOURCE tag is set to YES and SOURCE_BROWSER tag is set
10271027
# to YES then the hyperlinks from functions in REFERENCES_RELATION and
@@ -2081,7 +2081,7 @@ INCLUDE_FILE_PATTERNS =
20812081
# recursively expanded use the := operator instead of the = operator.
20822082
# This tag requires that the tag ENABLE_PREPROCESSING is set to YES.
20832083

2084-
PREDEFINED = _ARCH_PPC64
2084+
PREDEFINED = _ARCH_PPC64 _DOXYGEN_
20852085

20862086
# If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this
20872087
# tag can be used to specify a list of macro names that should be expanded. The

Doxyfile-man

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2080,7 +2080,7 @@ INCLUDE_FILE_PATTERNS =
20802080
# recursively expanded use the := operator instead of the = operator.
20812081
# This tag requires that the tag ENABLE_PREPROCESSING is set to YES.
20822082

2083-
PREDEFINED = _ARCH_PPC64
2083+
PREDEFINED = _ARCH_PPC64 _DOXYGEN_
20842084

20852085
# If the MACRO_EXPANSION and EXPAND_ONLY_PREDEF tags are set to YES then this
20862086
# tag can be used to specify a list of macro names that should be expanded. The

README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,20 +42,20 @@ areas on the the AFU. Endian conversion is handled automatically.
4242
# Usage
4343
A typical use of libocxl will follow this pattern:
4444

45-
1. **Setup:** optionally turn on error reporting within the library: ocxl\_want\_verbose\_errors().
45+
1. **Setup:** optionally turn on error reporting for the open calls: ocxl\_enable\_messages().
4646
2. **Open the device:** ocxl\_afu\_open() if an AFU name is used, or ocxl\_afu\_open\_from\_dev() if
47-
a device path is used.
48-
3. **Allocate IRQs:** ocxl\_afu\_irq\_alloc(). This returns a sequential per-AFU IRQ number.
47+
a device path is used. Optionally turn on error reporting for the AFU: ocxl\_afu\_enable\_messages().
48+
3. **Allocate IRQs:** ocxl\_irq\_alloc(). This returns a sequential per-AFU IRQ number.
4949
An opaque pointer is associated with the
5050
handle in which the caller can store additional information. This is not used by OpenCAPI,
5151
but is passed as part of the event information to provide additional context to the IRQ handler.
5252
4. **Configure global MMIO:** Some AFUs may have a global MMIO area, which will contain configuration
53-
information that will affect all PASIDs on the AFU. Use ocxl\_mmio\_map to make the area available,
53+
information that will affect all PASIDs on the AFU. Use ocxl\_mmio\_map() to make the area available,
5454
then use ocxl\_mmio\_write32() and ocxl\_mmio\_write64() to write the information.
5555
5. **Configure the per-PASID MMIO:** Some AFUs support multiple contexts, and each context will
5656
get it's own MMIO area for configuration and communication. Typical information that may
5757
be communicated across the MMIO interface include IRQ handles (obtained with
58-
ocxl\_afu\_irq\_get\_id()), and pointers to AFU-specific
58+
ocxl\_irq\_get\_handle()), and pointers to AFU-specific
5959
data structures. Use ocxl\_mmio\_map to make the area available, then use
6060
ocxl\_mmio\_write32() and ocxl\_mmio\_write64() to write the information.
6161
6. **Attach the AFU context to the process:** Use ocxl\_afu\_attach() to make the process's address space available
@@ -68,7 +68,7 @@ A typical use of libocxl will follow this pattern:
6868
the MMIO area. Typically, bulk data should be written to a pointer passed to the AFU, however,
6969
small quantities of data may be read from an MMIO area using ocxl\_mmio\_read32() and
7070
ocxl\_mmio\_read64().
71-
10. **Termination:** ocxl\_afu\_free() will free all resources associated with an AFU handle.
71+
10. **Termination:** ocxl\_afu\_close() will free all resources associated with an AFU handle.
7272

7373
# Development
7474
Patches may be submitted via Github pull requests. Please prepare your patches

0 commit comments

Comments
 (0)